Bug 78668

Summary: Remove an unnecessary public static factory function from ShadowRoot.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: DOMAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, morrita, rolandsteiner, shinyak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63606    
Attachments:
Description Flags
remove a factory
none
Patch for landing none

Hayato Ito
Reported 2012-02-14 21:52:55 PST
We don't have a client which calls the following public static function: static PassRefPtr<ShadowRoot> create(Document*); That should not be exposed.
Attachments
remove a factory (2.41 KB, patch)
2012-02-14 21:58 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.41 KB, patch)
2012-02-14 23:03 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-02-14 21:58:23 PST
Created attachment 127114 [details] remove a factory
Kent Tamura
Comment 2 2012-02-14 22:09:01 PST
Comment on attachment 127114 [details] remove a factory ok
Hayato Ito
Comment 3 2012-02-14 23:03:20 PST
Created attachment 127120 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-02-15 00:22:28 PST
Comment on attachment 127120 [details] Patch for landing Clearing flags on attachment: 127120 Committed r107786: <http://trac.webkit.org/changeset/107786>
WebKit Review Bot
Comment 5 2012-02-15 00:22:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.