Bug 78628

Summary: perf tests are flaky
Product: WebKit Reporter: Tony Chang <tony>
Component: Tools / TestsAssignee: Thiago Marcos P. Santos <tmpsantos>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, ossy, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 86800, 87267    
Bug Blocks: 63769, 78593    
Attachments:
Description Flags
patch none

Description Tony Chang 2012-02-14 13:28:08 PST 
We should consider running them at the end of new-run-webkit-tests without other processes running so they're less flaky.

Note that I already disabled them for debug builds because they're really flaky in debug.

I don't have time for this now, but someone else might!
Comment 1 Thiago Marcos P. Santos 2012-05-02 05:57:02 PDT 
Created attachment 139795 [details]
patch

Perf tests are affected by external factors (load, i/o, etc), makes sense to lock other threads when running them.

This patch solves the problem on my machine of perf tests flaking/timeouting when building a Debug version of EFL port. IMO we have such a few perf tests that it is OK to put them on the locked shard, should not affect the total elapsed time of running layout tests.
Comment 2 Tony Chang 2012-05-02 09:52:55 PDT 
Comment on attachment 139795 [details]
patch

Seems fine to me.  I'll give dirk a chance to review the code as well.  I'd also be curious to know how this impacts total running time, although I suspect it's relatively small.
Comment 3 Dirk Pranke 2012-05-03 14:20:59 PDT 
Comment on attachment 139795 [details]
patch

looks fine.
Comment 4 WebKit Review Bot 2012-05-03 15:08:50 PDT 
Comment on attachment 139795 [details]
patch

Clearing flags on attachment: 139795

Committed r116021: <http://trac.webkit.org/changeset/116021>
Comment 5 WebKit Review Bot 2012-05-03 15:08:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Thiago Marcos P. Santos 2012-05-04 02:21:18 PDT 
Got no flakes on perf anymore on the EFL buildbot and no change on the run-webkit-tests total time.
Comment 7 Csaba Osztrogonác 2012-05-23 08:27:10 PDT 
It caused a regression, could you check and fix it, please?
See https://bugs.webkit.org/show_bug.cgi?id=86800 for details.
Comment 8 Thiago Marcos P. Santos 2012-05-24 02:42:07 PDT 
(In reply to comment #7)
> It caused a regression, could you check and fix it, please?
> See https://bugs.webkit.org/show_bug.cgi?id=86800 for details.

Thanks for informing. Working on it right now.