Bug 78615

Summary: Initial upstreaming for find-in-page for BlackBerry port
Product: WebKit Reporter: Andy Chen <andchen>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Initial upstreaming for find-in-page for BlackBerry
rwlbuis: review-
Initial upstreaming for find-in-page for BlackBerry none

Description Andy Chen 2012-02-14 09:56:13 PST
Upstreaming InPageSearchManager.cpp and InPageSearchManager.h for BlackBerry port
Comment 1 Andy Chen 2012-02-14 11:53:48 PST
Created attachment 127009 [details]
Initial upstreaming for find-in-page for BlackBerry
Comment 2 Rob Buis 2012-02-14 12:36:19 PST
Comment on attachment 127009 [details]
Initial upstreaming for find-in-page for BlackBerry

View in context: https://bugs.webkit.org/attachment.cgi?id=127009&action=review

Some stuff still needs to be fixed.

> Source/WebKit/ChangeLog:5
> +

Maybe add an explanation why this change is made.

> Source/WebKit/blackberry/WebKitSupport/InPageSearchManager.h:41
> +    bool findNextString(const WTF::String& text, bool forward);

I dont think you need the WTF:: prefix.
Comment 3 Andy Chen 2012-02-14 12:55:01 PST
Created attachment 127022 [details]
Initial upstreaming for find-in-page for BlackBerry
Comment 4 Rob Buis 2012-02-14 12:59:23 PST
Comment on attachment 127022 [details]
Initial upstreaming for find-in-page for BlackBerry

Looks good.
Comment 5 WebKit Review Bot 2012-02-14 14:18:34 PST
Comment on attachment 127022 [details]
Initial upstreaming for find-in-page for BlackBerry

Clearing flags on attachment: 127022

Committed r107736: <http://trac.webkit.org/changeset/107736>
Comment 6 WebKit Review Bot 2012-02-14 14:18:38 PST
All reviewed patches have been landed.  Closing bug.