Summary: | Chrome V8 tracing is incomplete | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Rick Byers <rbyers> | ||||||||
Component: | JavaScriptCore | Assignee: | Rick Byers <rbyers> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, eric, jamesr, japhet, nduca, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Rick Byers
2012-02-13 10:37:03 PST
Created attachment 126794 [details]
Patch
Comment on attachment 126794 [details]
Patch
All Changes require a ChangeLog entry. But otherwise I doubt this is a controvesial change. :)
Comment on attachment 126794 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126794&action=review > Source/WebCore/bindings/v8/V8Proxy.cpp:431 > +#if PLATFORM_CHROMIUM This should be #if PLATFORM(CHROMIUM) Created attachment 126842 [details]
Patch
Thanks for the feedback - didn't realize people would look at my patch as soon as I uploaded it (as opposed to the Chromium process where we have to explicitly ask someone to review). Please see updated patch. Comment on attachment 126842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126842&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) The commit-queue will barf on this line. You'll need to replace this line with either an explanation of why testing is impossible/impractical (as is likely the case here) or list tests which cover this change. Created attachment 126848 [details]
Patch
Comment on attachment 126842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126842&action=review >> Source/WebCore/ChangeLog:8 >> + No new tests. (OOPS!) > > The commit-queue will barf on this line. You'll need to replace this line with either an explanation of why testing is impossible/impractical (as is likely the case here) or list tests which cover this change. Thanks, updated. Comment on attachment 126848 [details]
Patch
Thanks.
Comment on attachment 126848 [details] Patch Clearing flags on attachment: 126848 Committed r107685: <http://trac.webkit.org/changeset/107685> All reviewed patches have been landed. Closing bug. Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. |