Summary: | Web Inspector: wrap settings selector text and adding a rule with undoable actions. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, tony, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 78502 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Pavel Feldman
2012-02-13 03:51:58 PST
Created attachment 126748 [details]
Patch
Created attachment 126750 [details]
[Patch] with no fireStyleSheetChanged part.
Comment on attachment 126750 [details] [Patch] with no fireStyleSheetChanged part. View in context: https://bugs.webkit.org/attachment.cgi?id=126750&action=review > Source/WebCore/inspector/InspectorCSSAgent.cpp:709 > + *errorString = "No stylesheet to add rule to found"; Hard to parse. Perhaps, a simpler "No target stylesheet found"? > Source/WebCore/inspector/InspectorStyleSheet.cpp:798 > + sheetText.remove(sourceData->selectorListRange.start, sourceData->styleSourceData->styleBodyRange.end - sourceData->selectorListRange.start); Please check that this removes the rule body trailing '}' (add the full stylesheet text retrieval to your test.) Created attachment 126758 [details]
[Patch] review comments addressed.
(In reply to comment #3) > (From update of attachment 126750 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126750&action=review > > > Source/WebCore/inspector/InspectorCSSAgent.cpp:709 > > + *errorString = "No stylesheet to add rule to found"; > > Hard to parse. Perhaps, a simpler "No target stylesheet found"? > Done. > > Source/WebCore/inspector/InspectorStyleSheet.cpp:798 > > + sheetText.remove(sourceData->selectorListRange.start, sourceData->styleSourceData->styleBodyRange.end - sourceData->selectorListRange.start); > > Please check that this removes the rule body trailing '}' (add the full stylesheet text retrieval to your test.) Done. You actually caught a bug. Committed r107561: <http://trac.webkit.org/changeset/107561> inspector/styles/undo-add-new-rule.html is crashing in debug: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&group=%40ToT%20GPU%20Mesa%20-%20chromium.org&tests=fast%2Fcanvas%2Fcanvas-text-alignment.html (In reply to comment #7) > inspector/styles/undo-add-new-rule.html is crashing in debug: > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&group=%40ToT%20GPU%20Mesa%20-%20chromium.org&tests=fast%2Fcanvas%2Fcanvas-text-alignment.html Sorry, that was the wrong link: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Fstyles%2Fundo-add-new-rule.html I filed bug 78522 about the test crashing in debug. |