Bug 78461

Summary: Move attribute style invalidation to attributeChanged().
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+, webkit.review.bot: commit-queue-

Andreas Kling
Reported 2012-02-12 23:03:21 PST
Instead of doing it from parseAttribute() overloads.
Attachments
Patch (70.62 KB, patch)
2012-02-12 23:04 PST, Andreas Kling 		koivisto: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2012-02-12 23:04:04 PST
Created attachment 126719 [details] Patch
Antti Koivisto
Comment 2 2012-02-12 23:17:35 PST
Comment on attachment 126719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126719&action=review > Source/WebCore/html/HTMLPreElement.cpp:52 > +void HTMLPreElement::collectStyleForAttribute(Attribute* attr, StylePropertySet* style) collectStyleForAttribute() should be renamed to collectStyleForPresentationAttribute() to match isPresentationAttribute() > Source/WebCore/html/HTMLTableElement.cpp:359 > + if (attr->name() == widthAttr || attr->name() == heightAttr || attr->name() == bgcolorAttr || attr->name() == backgroundAttr || attr->name() == valignAttr || attr->name() == vspaceAttr || attr->name() == hspaceAttr || attr->name() == alignAttr || attr->name() == cellspacingAttr || attr->name() == borderAttr || attr->name() == bordercolorAttr || attr->name() == frameAttr || attr->name() == rulesAttr) Uh, this line is pretty long.
WebKit Review Bot
Comment 3 2012-02-12 23:59:00 PST
Comment on attachment 126719 [details] Patch Attachment 126719 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11504720 New failing tests: fast/forms/button-align.html fast/forms/textarea-align.html
Andreas Kling
Comment 4 2012-02-13 02:37:11 PST
Committed r107554: <http://trac.webkit.org/changeset/107554>
Note You need to log in before you can comment on or make changes to this bug.