Summary: | Add support for mozilla-style node constructors as properties of the window object | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||
Component: | DOM | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez | ||||
Priority: | P2 | ||||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 6519, 6622, 8197 | ||||||
Attachments: |
|
Description
Geoffrey Garen
2006-03-17 15:28:08 PST
We'll also need: HTMLElement XMLDocument When do you expect us see a breakthrough with these? Created attachment 8226 [details]
Patch
With this patch, local.live.com works without any error messages.
Comment on attachment 8226 [details]
Patch
I'm not happy about these classes that differ only in namespace; I hope that's a temporary situation.
For other classes I like to name the hand-coded ones differently, for example XXXBase. Worth considering if we have to leave the code like this for any length of time.
We also might want to use a new approach for half-generated classes where we can hand-write some functions rather than hand-writing an entire class, and teach the auto-generation code to write out declarations for the functions even if the functions themselves are hand-coded.
There should be a layout test for the new constructor objects, I don't see that here.
Assuming you add that layout test, r=me.
Mass moving XML DOM bugs to the "DOM" Component. |