Bug 78355

Summary:

Remove clipToImageBuffer from SourceAlpha and feComposite

Product:

WebKit

Reporter:

Zoltan Herczeg <zherczeg>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	zimmermann: review+

Description Zoltan Herczeg 2012-02-10 05:35:19 PST

Since clipToImageBuffer is mac specific, other platforms would benefit if we could remove it from the project.

Comment 1 Zoltan Herczeg 2012-02-10 05:40:37 PST

Created attachment 126507 [details]
patch

Comment 2 Zoltan Herczeg 2012-02-10 06:17:11 PST

I did some measurements on mac and Qt-Linux with the following filter combination:

<feFlood result="a" flood-color="red" flood-opacity="0.5" x="0" y="0" width="800" height="600"/>
<feFlood result="b" flood-color="green" flood-opacity="0.5" x="0" y="0" width="800" height="600"/>
<feComposite id="test" in="a" in2="b" operator="in"/>

Mac is unaffected by this change, but Qt is 10% faster (full browser).

Comment 3 Nikolas Zimmermann 2012-02-15 07:29:12 PST

Comment on attachment 126507 [details]
patch

r=me, this is a first step towards killing clipToImageBuffer, thus resolving some Qt crashes that recently appeared in that area.

Comment 4 Zoltan Herczeg 2012-02-15 07:56:40 PST

Landed as http://trac.webkit.org/changeset/107818