Bug 78343 – [GTK] security/block-test.html baselines differ from mac

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Philippe Normand]

--- LayoutTests/platform/mac/security/block-test-expected.txt	2011-12-28 16:17:03.000000000 +0100
+++ LayoutTests/platform/gtk/security/block-test-expected.txt	2012-02-10 11:55:33.000000000 +0100
@@ -1,152 +1,152 @@
 http://255.255.255.255:1/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:1/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
 <unknown> - didFinishLoading
-http://255.255.255.255:1/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:1/test.jpg">
+http://255.255.255.255:1/test.jpg - didFailLoadingWithError: <NSError domain WebKitPolicyError, code 103, failing URL "http://255.255.255.255:1/test.jpg">
...

Do we want to rename the GError domain from PolicyError to ErrorDomain or just deal with it in DRT?

[Martin Robinson]

Search and replace  in the DRT maybe?

[Philippe Normand]

(In reply to comment #1)
> Search and replace  in the DRT maybe?

We'd need to rename gquark stuff in the GError :) I'd be fine with that though!

[Martin Robinson]

I was just suggesting doing s/WebKitPolicyError/WebKitErrorDomain in the callback for didFailLoadingWithError.

[Philippe Normand]

Committed r109554: <http://trac.webkit.org/changeset/109554>

[Philippe Normand]

(In reply to comment #4)
> Committed r109554: <http://trac.webkit.org/changeset/109554>

Hum sorry this commit is partly wrong. There's no LayoutTests/security/block-test-expected.txt in ToT, NRWT played on me and generated one when I removed the gtk baseline :(

I'll work on a follow-up patch, sorry.

[Philippe Normand]

Created attachment 129901 [details]
Patch

[Philippe Normand]

Comment on attachment 129901 [details]
Patch

Clearing flags on attachment: 129901

Committed r109581: <http://trac.webkit.org/changeset/109581>

[Philippe Normand]

All reviewed patches have been landed.  Closing bug.