Bug 78312

Summary: Web Inspector: don't include a separator before "Inspect Element" context menu item when empty
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web Inspector (Deprecated)Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, gustavo, joepeck, keishi, loislo, pfeldman, pmuellr, pnormand, rik, timothy, webkit.review.bot, xan.lopez, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Change
none
Proposed Change (with build fix)
none
Proposed Change (with build fix, round 2) none

Timothy Hatcher
Reported 2012-02-09 18:42:57 PST
Don't inclue a seperator before the "Inspect Element" context menu item when the context menu is empty.
Attachments
Proposed Change (2.04 KB, patch)
2012-02-09 18:49 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Proposed Change (with build fix) (2.14 KB, patch)
2012-02-09 19:11 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Proposed Change (with build fix, round 2) (3.14 KB, patch)
2012-02-09 20:20 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2012-02-09 18:49:39 PST
Created attachment 126429 [details] Proposed Change
Philippe Normand
Comment 2 2012-02-09 19:03:52 PST
Comment on attachment 126429 [details] Proposed Change Attachment 126429 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11496176
Timothy Hatcher
Comment 3 2012-02-09 19:11:26 PST
Created attachment 126432 [details] Proposed Change (with build fix)
Gustavo Noronha (kov)
Comment 4 2012-02-09 19:14:56 PST
Comment on attachment 126432 [details] Proposed Change (with build fix) Attachment 126432 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11473479
Timothy Hatcher
Comment 5 2012-02-09 19:19:31 PST
Sigh, why is GTK still failing?
Timothy Hatcher
Comment 6 2012-02-09 20:12:18 PST
GTK must not implement ContextMenu::itemCount.
Timothy Hatcher
Comment 7 2012-02-09 20:20:43 PST
Created attachment 126440 [details] Proposed Change (with build fix, round 2)
Timothy Hatcher
Comment 8 2012-02-09 20:27:06 PST
It builds! Can someone review the GTK part?
Eric Seidel (no email)
Comment 9 2012-02-10 10:19:00 PST
Comment on attachment 126429 [details] Proposed Change Cleared Brian Weinstein's review+ from obsolete attachment 126429 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Eric Seidel (no email)
Comment 10 2012-02-10 10:19:03 PST
Comment on attachment 126432 [details] Proposed Change (with build fix) Cleared Timothy Hatcher's review+ from obsolete attachment 126432 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Brian Weinstein
Comment 11 2012-02-13 10:43:29 PST
Comment on attachment 126440 [details] Proposed Change (with build fix, round 2) Nice GTK Code :-).
WebKit Review Bot
Comment 12 2012-02-13 12:15:24 PST
Comment on attachment 126440 [details] Proposed Change (with build fix, round 2) Clearing flags on attachment: 126440 Committed r107593: <http://trac.webkit.org/changeset/107593>
WebKit Review Bot
Comment 13 2012-02-13 12:15:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.