Bug 78283

Summary: some tests in webkitpy are being run three times
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, levin, ojan, rniwa, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Description Dirk Pranke 2012-02-09 14:21:41 PST
some tests in webkitpy are being run three times
Comment 1 Dirk Pranke 2012-02-09 14:23:20 PST
Created attachment 126371 [details]
Patch
Comment 2 Dirk Pranke 2012-02-09 14:25:08 PST
people who often write unittests in python ... fyi.
Comment 3 Adam Barth 2012-02-09 14:28:15 PST
Comment on attachment 126371 [details]
Patch

Good to know!
Comment 4 Dirk Pranke 2012-02-09 14:33:26 PST
Committed r107293: <http://trac.webkit.org/changeset/107293>
Comment 5 Eric Seidel (no email) 2012-02-09 14:49:17 PST
Comment on attachment 126371 [details]
Patch

Why are we even importing these into other unittests in the first place...

How did you find these?  I assume by using the -v output?

How much faster did this make test-webkitpy? :))
Comment 6 Dirk Pranke 2012-02-09 15:21:23 PST
(In reply to comment #5)
> (From update of attachment 126371 [details])
> Why are we even importing these into other unittests in the first place...
> 
> How did you find these?  I assume by using the -v output?
> 

-v plus debugging a script I wrote that buckets the test times ...

> How much faster did this make test-webkitpy? :))

Not much, maybe a second.

For more details on test speed, see bug 78289, where I summarize what I've dug up recently in service of whether or not parallel testing would be worthwhile.