Bug 78262

Summary: Add roundedIntPoint method for LayoutPoints
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2012-02-09 11:58:03 PST
Add in a stub roundedIntPoint method that operates on a LayoutPoint and returns a rounded IntPoint, and pipe it through its usage.
Attachments
Patch (17.42 KB, patch)
2012-02-09 13:40 PST, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-02-09 13:40:01 PST
Created attachment 126363 [details] Patch
Eric Seidel (no email)
Comment 2 2012-02-09 14:58:12 PST
Comment on attachment 126363 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126363&action=review These seem OK. It's difficult for me to validate if they're correct. > Source/WebCore/page/EventHandler.cpp:1049 > + IntPoint mainFramePoint = mainView->rootViewToContents(resultView->contentsToRootView(roundedIntPoint(result.point()))); I guess our policy with hit testing is to round?
Emil A Eklund
Comment 3 2012-02-09 14:59:37 PST
(In reply to comment #2) > I guess our policy with hit testing is to round? At least for now. Making hit testing subpixel aware is something we want to do eventually.
Levi Weintraub
Comment 4 2012-02-09 15:09:42 PST
Comment on attachment 126363 [details] Patch Clearing flags on attachment: 126363 Committed r107296: <http://trac.webkit.org/changeset/107296>
Levi Weintraub
Comment 5 2012-02-09 15:09:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.