Summary: | [JSC] Add [ConstructorParameters=] to all custom constructors | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||
Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, darin, japhet, ojan, sam, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 77393 | ||||||
Attachments: |
|
Description
Kentaro Hara
2012-02-09 04:30:36 PST
I don't know much about this topic, but I suspect we should just remove them. Darin, Sam: Do you have any idea? As I understand it, this number is not just for caching. You can detect the number of arguments from JavaScript. Is that wrong? If the cache is a pure performance optimization, we can remove it if we show it has no effect on performance. We should not remove it just because of a guess that it has no effect. (In reply to comment #3) > As I understand it, this number is not just for caching. You can detect the number of arguments from JavaScript. Is that wrong? Sorry for leaving this bug without any update. You are completely right. What we need to do is - Remove [ConstructorParameters] from IDL files that have non-custom constructors. (If the IDL file has [Constructor(...)], CodeGeneratorJS.pm automatically sets the length property based on the signature. bug 78195) - Add [ConstructorParameters] to IDL files that have custom constructors. - Support [ConstructorParameters] in V8. (bug 78657) Created attachment 129013 [details]
Patch
Comment on attachment 129013 [details] Patch Clearing flags on attachment: 129013 Committed r109035: <http://trac.webkit.org/changeset/109035> All reviewed patches have been landed. Closing bug. |