Bug 78197 – The localization of htmlSelectMultipleItems() needs better support of pluralization

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Benjamin Poulain]

The pluralization of 0 and 1 depends on the language.

[Benjamin Poulain]

Created attachment 126228 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 126228 [details]
Patch

Can we ASSERT(count > 0) or even better convert its type to be unsigned [and then the localization to be %u]?

Likewise we could change the WEB_UI_STRING description string to be slightly different for 0 items and 1 items.
In the 0 case its a presentation string when there are no selected options, and the 1 is for just 1 selected option,
in a <select multiple>.

[Benjamin Poulain]

(In reply to comment #2)
> (From update of attachment 126228 [details])
> Can we ASSERT(count > 0) or even better convert its type to be unsigned [and then the localization to be %u]?

That is a good point, there is really no reason to use an int here. I will make a separate patch for that to avoid messing up our stuff too much.

[Alexey Proskuryakov]

It's not just 0 and 1 that are language dependent. For example, 20 and 21 need different noun forms in Russian. I believe that there are lots of other cases like this.

Is there a Radar bug tracking this issue? If there is one, please post its number in a comment, add it to ChangeLog, and add InRadar keyword.

[Benjamin Poulain]

Committed r107288: <http://trac.webkit.org/changeset/107288>

[Benjamin Poulain]

<rdar://problem/10814922>