| Summary: | [EFL][DRT] Add new expected layout results come from bug 78091. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kangil Han <kangil.han> | ||||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rniwa, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | Linux | ||||||||
| Bug Depends on: | 78091 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
Created attachment 126211 [details]
Patch
Comment on attachment 126211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126211&action=review LGTM except for bug title. > LayoutTests/ChangeLog:3 > + [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events. (2/2) It looks this bug title doesn't represent this bug's patch well. I changed bug title. Comment on attachment 126211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126211&action=review >> LayoutTests/ChangeLog:3 >> + [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events. (2/2) > > It looks this bug title doesn't represent this bug's patch well. You don't change bug title in ChangeLog. Created attachment 126247 [details]
Patch
Though patch is too huge, this is for expected results for layout test. LGTM. These patches can be landed by committers without reviews. Comment on attachment 126247 [details]
Patch
I can't really do a meaningful review here. I'm just going to rubber stamp it.
(In reply to comment #7) > These patches can be landed by committers without reviews. In case of test cases for EFL port, if it passes in informal review, I will land it without formal review. Comment on attachment 126247 [details] Patch Clearing flags on attachment: 126247 Committed r107539: <http://trac.webkit.org/changeset/107539> All reviewed patches have been landed. Closing bug. |
Implement zoomPage{In,Out} and textZoom{In,Out} events on EFL DRT. As a result, around 300 new expected results will be added in efl port.