Bug 78188

Summary: [EFL][DRT] Add new expected layout results come from bug 78091.
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Bug Depends on: 78091    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Kangil Han
Reported 2012-02-08 17:42:44 PST
Implement zoomPage{In,Out} and textZoom{In,Out} events on EFL DRT. As a result, around 300 new expected results will be added in efl port.
Attachments
Patch (1.19 MB, patch)
2012-02-08 17:55 PST, Kangil Han 		no flags
DetailsFormatted DiffDiff
Patch (1.19 MB, patch)
2012-02-08 23:58 PST, Kangil Han 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2012-02-08 17:55:11 PST
Created attachment 126211 [details] Patch
Gyuyoung Kim
Comment 2 2012-02-08 22:09:04 PST
Comment on attachment 126211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126211&action=review LGTM except for bug title. > LayoutTests/ChangeLog:3 > + [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events. (2/2) It looks this bug title doesn't represent this bug's patch well.
Kangil Han
Comment 3 2012-02-08 22:18:36 PST
I changed bug title.
Gyuyoung Kim
Comment 4 2012-02-08 23:33:36 PST
Comment on attachment 126211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126211&action=review >> LayoutTests/ChangeLog:3 >> + [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events. (2/2) > > It looks this bug title doesn't represent this bug's patch well. You don't change bug title in ChangeLog.
Kangil Han
Comment 5 2012-02-08 23:58:28 PST
Created attachment 126247 [details] Patch
Gyuyoung Kim
Comment 6 2012-02-09 04:25:12 PST
Though patch is too huge, this is for expected results for layout test. LGTM.
Ryosuke Niwa
Comment 7 2012-02-12 21:33:39 PST
These patches can be landed by committers without reviews.
Ryosuke Niwa
Comment 8 2012-02-12 21:34:51 PST
Comment on attachment 126247 [details] Patch I can't really do a meaningful review here. I'm just going to rubber stamp it.
Gyuyoung Kim
Comment 9 2012-02-12 22:03:33 PST
(In reply to comment #7) > These patches can be landed by committers without reviews. In case of test cases for EFL port, if it passes in informal review, I will land it without formal review.
WebKit Review Bot
Comment 10 2012-02-13 00:10:29 PST
Comment on attachment 126247 [details] Patch Clearing flags on attachment: 126247 Committed r107539: <http://trac.webkit.org/changeset/107539>
WebKit Review Bot
Comment 11 2012-02-13 00:10:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.