Bug 78173

Summary: Don't re-implement ZipFile.extractall
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED LATER    
Severity: Normal CC: dpranke, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71593    
Attachments:
Description Flags
Patch eric: review+, webkit.review.bot: commit-queue-

Adam Barth
Reported 2012-02-08 16:07:07 PST
Don't re-implement ZipFile.extractall
Attachments
Patch (2.91 KB, patch)
2012-02-08 16:08 PST, Adam Barth 		eric: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-02-08 16:08:41 PST
Created attachment 126177 [details] Patch
Adam Barth
Comment 2 2012-02-08 16:10:10 PST
Committed r107147: <http://trac.webkit.org/changeset/107147>
Dirk Pranke
Comment 3 2012-02-17 13:36:49 PST
This appears to break the autoinstaller using Python 2.6.1 on the Mac :( See bug 78866.
WebKit Review Bot
Comment 4 2012-02-17 13:42:16 PST
Comment on attachment 126177 [details] Patch Rejecting attachment 126177 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: commit-queue/ Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitpy/common/system/autoinstall.py Hunk #1 FAILED at 259. Hunk #2 FAILED at 313. 2 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/common/system/autoinstall.py.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11543261
Adam Barth
Comment 5 2012-02-20 19:54:56 PST
Looks like we need to keep this until we remove support for Python 2.6.
Note You need to log in before you can comment on or make changes to this bug.