Bug 78120

Summary:	rebaseline vertical text tests
Product:	WebKit	Reporter:	epoger
Component:	Tools / Tests	Assignee:	epoger
Status:	RESOLVED FIXED
Severity:	Normal	CC:	caryclark
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified

epoger

Reported 2012-02-08 09:00:44 PST

rebaseline the tests that are ignored by lines 3540-3568 in http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium/test_expectations.txt?rev=107094 : 3540 // use Skia to draw vertical text directly instead of text-on-path 3541 BUG_CARYCLARK MAC CPU : editing/selection/vertical-lr-ltr-extend-line-backward-br.html = IMAGE 3542 BUG_CARYCLARK MAC CPU : editing/selection/vertical-lr-ltr-extend-line-forward-br.html = IMAGE 3543 BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-backward-br.html = IMAGE 3544 BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-backward-p.html = IMAGE 3545 BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-backward-wrap.html = IMAGE 3546 BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-forward-br.html = IMAGE 3547 BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-forward-p.html = IMAGE 3548 BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-forward-wrap.html = IMAGE 3549 BUG_CARYCLARK MAC CPU : fast/dynamic/text-combine.html = IMAGE 3550 BUG_CARYCLARK MAC CPU : fast/repaint/japanese-rl-selection-clear.html = IMAGE 3551 BUG_CARYCLARK MAC CPU : fast/repaint/japanese-rl-selection-repaint-in-regions.html = IMAGE 3552 BUG_CARYCLARK MAC CPU : fast/repaint/japanese-rl-selection-repaint.html = IMAGE 3553 BUG_CARYCLARK MAC CPU : fast/repaint/repaint-across-writing-mode-boundary.html = IMAGE 3554 BUG_CARYCLARK SNOWLEOPARD LION CPU : fast/text/international/vertical-text-glyph-test.html = IMAGE 3555 BUG_CARYCLARK SNOWLEOPARD LION CPU : fast/text/justify-ideograph-vertical.html = IMAGE 3556 BUG_CARYCLARK MAC CPU : fast/writing-mode/Kusa-Makura-background-canvas.html = IMAGE 3557 BUG_CARYCLARK MAC CPU : fast/writing-mode/border-vertical-lr.html = IMAGE 3558 BUG_CARYCLARK MAC CPU : fast/writing-mode/broken-ideographic-font.html = IMAGE+TEXT IMAGE PASS 3559 BUG_CARYCLARK MAC CPU : fast/writing-mode/fallback-orientation.html = IMAGE 3560 BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-lr-text.html = IMAGE 3561 BUG_CARYCLARK SNOWLEOPARD LION CPU : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE 3562 BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-rl-text.html = IMAGE 3563 BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-ruby-vertical-lr.html = IMAGE 3564 BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-ruby-vertical-rl.html = IMAGE 3565 BUG_CARYCLARK SNOWLEOPARD LION CPU : fast/writing-mode/text-orientation-basic.html = IMAGE 3566 BUG_CARYCLARK MAC CPU : fast/writing-mode/vertical-align-table-baseline.html = IMAGE 3567 BUG_CARYCLARK MAC CPU : fast/writing-mode/vertical-baseline-alignment.html = IMAGE 3568 BUG_CARYCLARK MAC CPU : fast/writing-mode/vertical-font-fallback.html = IMAGE

Attachments
Add attachment proposed patch, testcase, etc.

epoger

Comment 1 2012-02-08 09:13:50 PST

Cary- please confirm that these rebaseline results look right to you: http://www.corp.google.com/~epoger/rebaselines/2012-02-08-09-11-39/rebaseline.html

Cary Clark

Comment 2 2012-02-08 11:53:01 PST

LGTM (In reply to comment #1) > Cary- please confirm that these rebaseline results look right to you: > http://www.corp.google.com/~epoger/rebaselines/2012-02-08-09-11-39/rebaseline.html

epoger

Comment 3 2012-02-08 12:24:50 PST

Committed r107114: <http://trac.webkit.org/changeset/107114>

Note You need to log in before you can comment on or make changes to this bug.