Summary: | Add unprefixed Blob.webkitSlice (slice) | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Pieters (:zcorpan) <zcorpan> | ||||||||||||||||
Component: | New Bugs | Assignee: | Kinuko Yasuda <kinuko> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | abarth, annevk, dglazkov, fishd, gustavo, jianli, kinuko, ojan, philn, tzik, webkit.review.bot, xan.lopez | ||||||||||||||||
Priority: | P2 | Keywords: | WebExposed | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Simon Pieters (:zcorpan)
2012-02-08 06:08:07 PST
Created attachment 146823 [details]
Patch
Comment on attachment 146823 [details] Patch Attachment 146823 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12943214 Created attachment 146833 [details]
Patch
Created attachment 146839 [details]
Patch
Created attachment 146843 [details]
Patch
Comment on attachment 146843 [details] Patch Attachment 146843 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12941324 Created attachment 146848 [details]
Patch
Comment on attachment 146848 [details] Patch Attachment 146848 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12941361 New failing tests: fast/filesystem/workers/file-writer-truncate-extend.html fast/filesystem/workers/file-writer-write-overlapped.html fast/filesystem/file-writer-truncate-extend.html inspector/profiler/heap-snapshot-loader.html Created attachment 146867 [details]
Archive of layout-test-results from ec2-cr-linux-04
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 147024 [details]
Patch
Could someone review this? Comment on attachment 147024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147024&action=review > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:32 > -WEBKIT_API WebKitDOMBlob* webkit_dom_blob_slice(WebKitDOMBlob* self, gint64 start, gint64 end, const gchar* content_type); > +WEBKIT_API WebKitDOMBlob* webkit_dom_blob_webkit_slice(WebKitDOMBlob* self, gint64 start, gint64 end, const gchar* content_type); Why the addition of "webkit" here? I would have thought we'd be happy with fewer webkits, not more. > Source/WebCore/fileapi/Blob.cpp:97 > + String message("Blob.webkitSlice() is deprecated. Use Blob.slice() instead ."); Looks like you've got an extra space before the . > Source/WebCore/fileapi/Blob.h:75 > + // Prefixed version is going to be deprecated. This internally calls sliceInternal() (as slice() does) after showing a deprecation message. "is going to be deprecated" => "is deprecated" :) (In reply to comment #12) > (From update of attachment 147024 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147024&action=review > > > Source/WebCore/bindings/gobject/WebKitDOMCustom.h:32 > > -WEBKIT_API WebKitDOMBlob* webkit_dom_blob_slice(WebKitDOMBlob* self, gint64 start, gint64 end, const gchar* content_type); > > +WEBKIT_API WebKitDOMBlob* webkit_dom_blob_webkit_slice(WebKitDOMBlob* self, gint64 start, gint64 end, const gchar* content_type); > > Why the addition of "webkit" here? I would have thought we'd be happy with fewer webkits, not more. It's for keeping backward compatibility, because I added !LANGUAGE_GOBJECT not to generate webkitSlice binding for gobject as its binding doesn't support CallWith=ScriptExecutionContext. (Hope this works for gtk) > > Source/WebCore/fileapi/Blob.cpp:97 > > + String message("Blob.webkitSlice() is deprecated. Use Blob.slice() instead ."); > > Looks like you've got an extra space before the . > > > Source/WebCore/fileapi/Blob.h:75 > > + // Prefixed version is going to be deprecated. This internally calls sliceInternal() (as slice() does) after showing a deprecation message. > > "is going to be deprecated" => "is deprecated" :) Will fix these nits. Thanks for your review! Ah! I understand. Thanks. :) Committed r120165: <http://trac.webkit.org/changeset/120165> |