Bug 78091

Summary:

[EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.

Product:

WebKit

Reporter:

Kangil Han <kangil.han>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Bug Depends on:

Bug Blocks:

78188

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Kangil Han

Reported 2012-02-08 02:05:29 PST

Implement zoomPage{In,Out} and textZoom{In,Out} events on EFL DRT. As a result, around 300 new expected results will be added in efl port.

Attachments
Patch (1.01 MB, patch) 2012-02-08 17:40 PST, Kangil Han	no flags	Details Formatted Diff Diff
Patch (1.01 MB, patch) 2012-02-09 00:05 PST, Kangil Han	no flags	Details Formatted Diff Diff
Patch (1.01 MB, patch) 2012-02-12 18:07 PST, Kangil Han	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Kangil Han

Comment 1 2012-02-08 17:40:16 PST

Created attachment 126204 [details] Patch

Gyuyoung Kim

Comment 2 2012-02-08 19:46:12 PST

Though patch is too huge, I think EFL DRT needs this patch. LGTM.

Kangil Han

Comment 3 2012-02-09 00:05:39 PST

Created attachment 126248 [details] Patch

Hajime Morrita

Comment 4 2012-02-12 17:04:13 PST

Comment on attachment 126248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126248&action=review I recommend to split the patch into code-only part and rebaselining until efl DRT is available on the bot. Rebaselining is kinda semi automatic stuff but the code change is not. > Tools/DumpRenderTree/efl/EventSender.cpp:454 > +static void textZoom(bool zoomIn) Enum would be better in these case. > Tools/DumpRenderTree/efl/EventSender.cpp:469 > +static void pageZoom(bool zoomIn) Enum would be better in these case.

Gyuyoung Kim

Comment 5 2012-02-12 17:37:34 PST

(In reply to comment #4) > (From update of attachment 126248 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126248&action=review > > I recommend to split the patch into code-only part and rebaselining until efl DRT is available on the bot. > Rebaselining is kinda semi automatic stuff but the code change is not. I will guide to split between code-only part and test codes. > > Tools/DumpRenderTree/efl/EventSender.cpp:454 > > +static void textZoom(bool zoomIn) > > Enum would be better in these case. > > > Tools/DumpRenderTree/efl/EventSender.cpp:469 > > +static void pageZoom(bool zoomIn) > > Enum would be better in these case. Kangil, could you change zoomIn parameter with enum type? Moritta, I'm build efl test bot on Bug 77518 and Bug78348. I think you're able to enough to review Bug 78348. Could you do that ?

Kangil Han

Comment 6 2012-02-12 18:07:20 PST

Created attachment 126696 [details] Patch

WebKit Review Bot

Comment 7 2012-02-12 21:27:08 PST

Comment on attachment 126696 [details] Patch Clearing flags on attachment: 126696 Committed r107529: <http://trac.webkit.org/changeset/107529>

WebKit Review Bot

Comment 8 2012-02-12 21:27:15 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.