| Summary: | [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kangil Han <kangil.han> | ||||||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | Linux | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 78188 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 126204 [details]
Patch
Though patch is too huge, I think EFL DRT needs this patch. LGTM. Created attachment 126248 [details]
Patch
Comment on attachment 126248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126248&action=review I recommend to split the patch into code-only part and rebaselining until efl DRT is available on the bot. Rebaselining is kinda semi automatic stuff but the code change is not. > Tools/DumpRenderTree/efl/EventSender.cpp:454 > +static void textZoom(bool zoomIn) Enum would be better in these case. > Tools/DumpRenderTree/efl/EventSender.cpp:469 > +static void pageZoom(bool zoomIn) Enum would be better in these case. (In reply to comment #4) > (From update of attachment 126248 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126248&action=review > > I recommend to split the patch into code-only part and rebaselining until efl DRT is available on the bot. > Rebaselining is kinda semi automatic stuff but the code change is not. I will guide to split between code-only part and test codes. > > Tools/DumpRenderTree/efl/EventSender.cpp:454 > > +static void textZoom(bool zoomIn) > > Enum would be better in these case. > > > Tools/DumpRenderTree/efl/EventSender.cpp:469 > > +static void pageZoom(bool zoomIn) > > Enum would be better in these case. Kangil, could you change zoomIn parameter with enum type? Moritta, I'm build efl test bot on Bug 77518 and Bug78348. I think you're able to enough to review Bug 78348. Could you do that ? Created attachment 126696 [details]
Patch
Comment on attachment 126696 [details] Patch Clearing flags on attachment: 126696 Committed r107529: <http://trac.webkit.org/changeset/107529> All reviewed patches have been landed. Closing bug. |
Implement zoomPage{In,Out} and textZoom{In,Out} events on EFL DRT. As a result, around 300 new expected results will be added in efl port.