Bug 7808 – Assertion failure in -[WebBaseNetscapePluginStream dealloc] when requesting an invalid URL

• Component: Plug-ins
• Status: RESOLVED FIXED

[Gibbons Burke]

The web page listed in the URL field freezes Safari and the Nightly Build Webkit app every time I try and bring it up. I get the spinning beachball before the page finishes loading and the following messages appear in my Console log: 

(event handler):Undefined value
(event handler):Undefined value
[1694] http://www.wdsu.com/video/index.html line 40: ReferenceError: Can't find variable: videoplug
[1694] http://www.wdsu.com/video/index.html line 44: TypeError: Undefined value
[1694] http://www.wdsu.com/video/index.html line 50: ReferenceError: Can't find variable: NewState

[Richard Das]

Same here. Looks like same behavior as when rapidly clicking several links in an rss feed to open in new tabs. Pages start to load, then you get the beach ball.

[Alexey Proskuryakov]

=================
ASSERTION FAILED: !instance (/Users/ap/WebKit/WebKit/Plugins/WebBaseNetscapePluginStream.m:107 -[WebBaseNetscapePluginStream dealloc])
=================

0   com.apple.WebKit               	0x0031b640 -[WebBaseNetscapePluginStream dealloc] + 96 (WebBaseNetscapePluginStream.m:107)
1   com.apple.WebKit               	0x0032cd34 -[WebNetscapePluginStream dealloc] + 160 (WebNetscapePluginStream.m:99)
2   com.apple.WebKit               	0x0032cb3c -[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:] + 472 (WebNetscapePluginStream.m:78)
3   com.apple.WebKit               	0x00324ca0 -[WebBaseNetscapePluginView(WebNPPCallbacks) loadRequest:inTarget:withNotifyData:sendNotification:] + 872 (WebBaseNetscapePluginView.m:1603)
4   com.apple.WebKit               	0x00324ec8 -[WebBaseNetscapePluginView(WebNPPCallbacks) getURL:target:] + 176 (WebBaseNetscapePluginView.m:1628)
5   com.apple.WebKit               	0x003314d4 NPN_GetURL + 88 (npapi.m:88)
6   Windows Media Plugin           	0x13217968 0x13205000 + 76136
7   Windows Media Plugin           	0x13218c70 0x13205000 + 81008
8   Windows Media Plugin           	0x13217ab0 0x13205000 + 76464
9   com.apple.WebKit               	0x00321944 -[WebBaseNetscapePluginView start] + 676 (WebBaseNetscapePluginView.m:1000)
10  com.apple.WebKit               	0x00323278 -[WebBaseNetscapePluginView viewDidMoveToWindow] + 132 (WebBaseNetscapePluginView.m:1306)

[Alexey Proskuryakov]

Forgot to mention that I cannot reproduce the freeze with stock 2.0.3/10.4.5, but the assertion failure looks scary enough. See also: bug 7762.

[Eric Seidel (no email)]

The subframe scrollbar on the right hand side (list of videos) doesn't seem to work on 2.0.3  However I don't see the page hang in 2.0.3.

[Darin Adler]

Looks like the assertion is related to GC changes to plug-in classes.

[Alice Liu]

<rdar://problem/4549734>

[Darin Adler]

After doing some quick analysis, this looks like the event listener problem that's also causing a hang on the digg.com site, bug 7657.

[Darin Adler]

Or maybe just a runaway for loop.

[Alexey Proskuryakov]

Created attachment 9370 [details]
fix assertion failure

The plugin was requesting an invalid (empty) URL, and this fix just removes an early return in this case. Not sure why it was there, NSURLConnection seems to handle this nicely. BTW, looks scarily similar to the completely unrelated bug 9802 :)

As noted in comment 4, scrollbars in subframes don't work, but this is certainly a separate issue.

[Tim Omernick]

Comment on attachment 9370 [details]
fix assertion failure

Looks good!  r=me

[Alexey Proskuryakov]

Committed revision 15337. Filed the scroll bars issue as bug 9855. Please file additional bugs if there are more problems remaining on this site.

[Tim Omernick]

(In reply to comment #6)
> <rdar://problem/4549734>
> 


This does *not* appear to be the same as Radar 4549734.  It looks much more like Radar 4594198.