Bug 78050

Summary: Scrolling tree should keep track of region we can't do fast scrolling for
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mitz, simon.fraser, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Anders Carlsson
Reported 2012-02-07 15:21:47 PST
Scrolling tree should keep track of region we can't do fast scrolling for
Attachments
Patch (12.52 KB, patch)
2012-02-07 15:26 PST, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-02-07 15:26:31 PST
Created attachment 125944 [details] Patch
mitz
Comment 2 2012-02-07 15:36:55 PST
Comment on attachment 125944 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125944&action=review > Source/WebCore/page/FrameView.cpp:2552 > +IntRect FrameView::scrollableAreaBoundingBox() const Why are scrollbars included in the scrollable area? > Source/WebCore/page/FrameView.h:374 > + virtual IntRect scrollableAreaBoundingBox() const; Why not OVERRIDE? > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:103 > + // such as subframes, overflow divs and render list boxes. I’d just say “list boxes”. > Source/WebCore/rendering/RenderLayer.h:325 > + virtual IntRect scrollableAreaBoundingBox() const; Why public, why not OVERRIDE? > Source/WebCore/rendering/RenderListBox.h:123 > + virtual IntRect scrollableAreaBoundingBox() const; Why not OVERRIDE?
Anders Carlsson
Comment 3 2012-02-07 15:44:34 PST
(In reply to comment #2) > (From update of attachment 125944 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125944&action=review > > > Source/WebCore/page/FrameView.cpp:2552 > > +IntRect FrameView::scrollableAreaBoundingBox() const > > Why are scrollbars included in the scrollable area? Because when you have your mouse over a scrollbar, you don't want to do fast scrolling. > > > Source/WebCore/page/FrameView.h:374 > > + virtual IntRect scrollableAreaBoundingBox() const; > > Why not OVERRIDE? Fixed. > > > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:103 > > + // such as subframes, overflow divs and render list boxes. > > I’d just say “list boxes”. Fixed. > > > Source/WebCore/rendering/RenderLayer.h:325 > > + virtual IntRect scrollableAreaBoundingBox() const; > > Why public, why not OVERRIDE? Fixed. > > > Source/WebCore/rendering/RenderListBox.h:123 > > + virtual IntRect scrollableAreaBoundingBox() const; > > Why not OVERRIDE? Fixed. Thanks for reviewing!
Anders Carlsson
Comment 4 2012-02-07 15:50:11 PST
Committed r107001: <http://trac.webkit.org/changeset/107001>
Note You need to log in before you can comment on or make changes to this bug.