Bug 77967

Summary:

Web Inspector: Optional out arguments are not supported in the Web Inspector protocol, which breaks the implementation

Product:

WebKit

Reporter:

Alexander Pavlov (apavlov) <apavlov>

Component:

Web Inspector (Deprecated)

Assignee:

Peter Rybin <peter.rybin>

Status:

RESOLVED FIXED

Severity:

Major

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, prybin, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
original InspectorBackendDispatcher.cpp	none
new InspectorBackendDispatcher.cpp	none

Alexander Pavlov (apavlov)

Reported 2012-02-07 04:53:52 PST

Please fix ASAP.

Attachments
Patch (2.17 KB, patch) 2012-02-07 14:09 PST, Peter Rybin	no flags	Details Formatted Diff Diff
original InspectorBackendDispatcher.cpp (189.89 KB, text/plain) 2012-02-08 07:32 PST, Peter Rybin	no flags	Details
new InspectorBackendDispatcher.cpp (189.83 KB, text/plain) 2012-02-08 07:33 PST, Peter Rybin	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Peter Rybin

Comment 1 2012-02-07 14:09:31 PST

Created attachment 125924 [details] Patch

Peter Rybin

Comment 2 2012-02-07 14:15:32 PST

Alexander, I propose this patch. It support optional returns for RefPtr-based types. However you would have to manually clear RefPtr in order to not return a value. You might expect that the proper way would be to pass empty RefPtr in the first place, but unfortunately this is much harder to implement right now and it would interfere with a refactoring that I'm doing on the same part of generator code. Please consider using this schema as a temporary solution. You can put FIXME comment at each RefPtr clearing site. I'm going to iterate over all returns in the future when landing my refactoring.

Yury Semikhatsky

Comment 3 2012-02-08 06:03:09 PST

Could you attach generated files diff?

Peter Rybin

Comment 4 2012-02-08 07:32:18 PST

Created attachment 126080 [details] original InspectorBackendDispatcher.cpp

Peter Rybin

Comment 5 2012-02-08 07:33:54 PST

Created attachment 126081 [details] new InspectorBackendDispatcher.cpp

WebKit Review Bot

Comment 6 2012-02-08 08:17:36 PST

Comment on attachment 125924 [details] Patch Clearing flags on attachment: 125924 Committed r107091: <http://trac.webkit.org/changeset/107091>

WebKit Review Bot

Comment 7 2012-02-08 08:17:41 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.