Bug 77918

Summary: Revert TableSection cell and border calculations to int
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric, leviw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Emil A Eklund 2012-02-06 17:35:23 PST
This is a follow up to bug 71500 where table layout was changed back to integers.
Comment 1 Emil A Eklund 2012-02-06 17:40:03 PST
Created attachment 125739 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-06 17:51:55 PST
Comment on attachment 125739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125739&action=review

> Source/WebCore/ChangeLog:9
> +        Change RenderTableSection cell width, row height and border calculations
> +        back to use integers.

Why?
Comment 3 Emil A Eklund 2012-02-06 17:57:05 PST
We use integers for table layout, to ensure even sizing of cells, and borders. Most of table layout was reverted back to integers in bug 71500.
Comment 4 Eric Seidel (no email) 2012-02-07 12:26:24 PST
Comment on attachment 125739 [details]
Patch

OK.  So I'm OK with this change.  But please update the ChangeLog to explain why Tables are special, and explicitly always use ints for their layout.  You explained in person that this was part of the spec (that columns needed to be exactly equal width with each other).  But it's importnat to record that wisdom/justification in the ChangeLog itself (for others looking at this change now or later).
Comment 5 Darin Adler 2012-02-07 12:29:11 PST
ChangeLog, but maybe code too. We really want future programmers to be able to discover this sort of thing.
Comment 6 Emil A Eklund 2012-02-07 18:29:28 PST
(In reply to comment #5)
> ChangeLog, but maybe code too. We really want future programmers to be able to discover this sort of thing.

I'll add a comment in the main Table renderer class in a separate change.
Thanks.
Comment 7 Emil A Eklund 2012-02-07 18:33:40 PST
Created attachment 125978 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-02-07 21:38:11 PST
Comment on attachment 125978 [details]
Patch for landing

Clearing flags on attachment: 125978

Committed r107038: <http://trac.webkit.org/changeset/107038>
Comment 9 WebKit Review Bot 2012-02-07 21:38:15 PST
All reviewed patches have been landed.  Closing bug.