Bug 77906
| Summary: | Review page takes forever to load when the patch is big | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, jchaffraix, kling, koivisto, morrita, tonikitoo, zalan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Both ToT WebKit and Chromium appears to hang when I try to open:
https://bugs.webkit.org/attachment.cgi?id=125284&action=review
It's only 2.14MB! WebKit shouldn't be hanging on this page.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Note the patch is for https://bugs.webkit.org/show_bug.cgi?id=77504.
Antonio Gomes
on my blackerry device it rebooted the phone, on iphone it killed the browser...
Ryosuke Niwa
Just note that this bug is about fixing WebKit to load it fast, not about "fixing" our Bugzilla.
Ahmad Saleem
@ap - Now that we have moved to GitHub for review, do you think it is OK to keep it open. Also devices has evolved a lot and also I am not able to open link from Comment 0 but this also work (another 1.4 MB one):
https://bugs.webkit.org/attachment.cgi?id=125233&action=review
It takes time to load in Safari & Chrome but should we keep it as open for performance profiling?
Alexey Proskuryakov
There were a lot of line layout performance improvements lately, and indeed, large patches appears to work well now.
At this point, patches in Bugzilla remain a supported way to contribute to WebKit.