Bug 77855

Summary: ValueToNumber and ValueToDouble nodes don't do anything and should be removed
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
barraclough: review+
the patch barraclough: review+

Filip Pizlo
Reported 2012-02-05 23:20:04 PST
If we have a and b both predicted number, then the following sequence: 1: ValueToNumber(a) 2: ValueToNumber(b) 3: ArithSub(@1, @2) should be turned into: 1: ValueToNumberPure(a) (skipped) 2: ValueToNumberPure(b) (skipped) 3: ArithSub(a, b) and hence we skip two moves and save a register.
Attachments
the patch (14.84 KB, patch)
2012-02-06 00:44 PST, Filip Pizlo 		barraclough: review+
DetailsFormatted DiffDiff
the patch (21.50 KB, patch)
2012-02-06 16:04 PST, Filip Pizlo 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-02-05 23:56:23 PST
<rdar://problem/10811325>
Filip Pizlo
Comment 2 2012-02-06 00:44:16 PST
Created attachment 125590 [details] the patch
Filip Pizlo
Comment 3 2012-02-06 16:04:26 PST
Created attachment 125721 [details] the patch
Filip Pizlo
Comment 4 2012-02-06 17:10:15 PST
Landed in http://trac.webkit.org/changeset/106879
Note You need to log in before you can comment on or make changes to this bug.