Bug 77852

Summary: Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet], [DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, japhet, macpherson, menard, ojan, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77393    
Attachments:
Description Flags
Patch
none
rebased patch for commit
none
rebased patch for commit none

Kentaro Hara
Reported 2012-02-05 22:48:46 PST
We can rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet], [DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification. [DontCheckEnums] => [DoNotCheckConstants] (This IDL inserts assertions to check if a constant value are equal to the expected constant value) [ReturnsNew] => [ReturnNewObject] (For clarification) [DoNotCheckDomainSecurityOnGet] => [DoNotCheckDomainSecurityOnGetter] (For naming consistency with other [*Getter] IDLs) [DoNotCheckDomainSecurityOnSet] => [DoNotCheckDomainSecurityOnSetter] (For naming consistency with other [*Setter] IDLs) [ImplementationFunction=] => [ImplementedAs=] (For clarification. This IDL specifies the method name in implementation)
Attachments
Patch (51.65 KB, patch)
2012-02-05 22:55 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
rebased patch for commit (52.05 KB, patch)
2012-02-06 17:31 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
rebased patch for commit (51.56 KB, patch)
2012-02-06 18:41 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-05 22:55:56 PST
Created attachment 125577 [details] Patch
Kentaro Hara
Comment 2 2012-02-06 17:31:34 PST
Created attachment 125737 [details] rebased patch for commit
Kentaro Hara
Comment 3 2012-02-06 17:33:56 PST
Committed r106883: <http://trac.webkit.org/changeset/106883>
Kentaro Hara
Comment 4 2012-02-06 17:34:41 PST
Comment on attachment 125577 [details] Patch Landed manually to avoid style check errors in generated code for GTK.
Kentaro Hara
Comment 5 2012-02-06 18:04:42 PST
Reverted r106883 for reason: build failure around Chromium V8 bindings Committed r106889: <http://trac.webkit.org/changeset/106889>
Kentaro Hara
Comment 6 2012-02-06 18:41:32 PST
Created attachment 125749 [details] rebased patch for commit
Kentaro Hara
Comment 7 2012-02-06 18:43:53 PST
Committed r106892: <http://trac.webkit.org/changeset/106892>
Note You need to log in before you can comment on or make changes to this bug.