Bug 77822

Summary: Clients cannot prevent caching of individual responses
Product: WebKit Reporter: mitz
Component: WebKit APIAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add WKBundlePageResourceLoadClient::shouldCacheResponse sam: review+

Description mitz 2012-02-04 17:27:09 PST
Clients cannot prevent caching of individual responses
Comment 1 mitz 2012-02-04 17:28:29 PST
<rdar://problem/10660698>
Comment 2 mitz 2012-02-04 17:35:01 PST
Created attachment 125508 [details]
Add WKBundlePageResourceLoadClient::shouldCacheResponse
Comment 3 WebKit Review Bot 2012-02-04 17:37:27 PST
Attachment 125508 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/Shared/APIClientTraits.h:46:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Sam Weinig 2012-02-04 18:45:15 PST
Comment on attachment 125508 [details]
Add WKBundlePageResourceLoadClient::shouldCacheResponse

View in context: https://bugs.webkit.org/attachment.cgi?id=125508&action=review

>> Source/WebKit2/Shared/APIClientTraits.h:46
>> +{
> 
> This { should be at the end of the previous line  [whitespace/braces] [4]

The { is on the wrong line.
Comment 5 mitz 2012-02-04 18:54:56 PST
Fixed in <http://trac.webkit.org/r106753>.