| Summary: | WKPreferences instances cannot be copied | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||
| Component: | WebKit API | Assignee: | mitz | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, darin, mrowe, rniwa | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
mitz
2012-02-04 15:53:21 PST
Created attachment 125504 [details]
Add WKPreferencesCreateCopy()
Fixed in <http://trac.webkit.org/r106749>. In GCC, I'm getting the following compilation error:
cc1plus: warnings being treated as errors
/Volumes/Data/webkit4/Source/WebKit2/UIProcess/WebPreferences.cpp: In copy constructor 'WebKit::WebPreferences::WebPreferences(const WebKit::WebPreferences&)':
/Volumes/Data/webkit4/Source/WebKit2/UIProcess/WebPreferences.cpp:44: warning: base class 'class WebKit::APIObject' should be explicitly initialized in the copy constructor
PhaseScriptExecution "Check For Framework Include Consistency" /Volumes/Data/webkit4/WebKitBuild/WebKit2.build/Debug/WebKit2.build/Script-5DF408C6131DD49700130071.sh
cd /Volumes/Data/webkit4/Source/WebKit2
"Fixed" in http://trac.webkit.org/changeset/106824. I'm not happy about using the default constructor of APIObject but I couldn't figure out a good way to fix it properly without being invasive here. Maybe andersca, bdash, or darin would know? I think your fix was correct. (In reply to comment #7) > I think your fix was correct. That is good to hear. |