Summary: | Canvas-into-canvas drawing should respect backing store scale ratio | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||
Component: | Canvas | Assignee: | Tim Horton <thorton> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | adele, dglazkov, eoconnor, mdelaney7, mitz, simon.fraser, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Tim Horton
2012-02-03 14:44:12 PST
Created attachment 125419 [details]
patch
Comment on attachment 125419 [details]
patch
Makes sense
(In reply to comment #2) > (From update of attachment 125419 [details]) > Makes sense Only mostly... there's one mistake: the destination rect should be equal to the source rect, not the size of the destination canvas. I *did* have that right last time; gotta stop second-guessing. r=you with that change? Comment on attachment 125419 [details] patch Attachment 125419 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11424456 New failing tests: fast/canvas/canvas-composite-canvas.html canvas/philip/tests/2d.fillStyle.parse.current.removed.html (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 125419 [details] [details]) > > Makes sense > > Only mostly... there's one mistake: the destination rect should be equal to the source rect, not the size of the destination canvas. I *did* have that right last time; gotta stop second-guessing. r=you with that change? I was going to say yes, but what's this failure the EWS bot is reporting? (In reply to comment #5) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 125419 [details] [details] [details]) > > > Makes sense > > > > Only mostly... there's one mistake: the destination rect should be equal to the source rect, not the size of the destination canvas. I *did* have that right last time; gotta stop second-guessing. r=you with that change? > > I was going to say yes, but what's this failure the EWS bot is reporting? I'm going to double check in a minute, but I'm willing to bet that *is* the failure the EWS bot is reporting. For some reason I didn't hit that when running the tests locally, though, so I have to figure out how to get it to fail! Could you post the corrected version of the patch to see what the bit thinks about it? Created attachment 125463 [details]
revised patch
Sure, let's see what EWS says.
Comment on attachment 125463 [details] revised patch Attachment 125463 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11421531 Comment on attachment 125463 [details] revised patch Attachment 125463 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11416605 Created attachment 125465 [details]
revised patch (which actually builds!)
Ugh, I undo'd a little too far.
Landed in http://trac.webkit.org/changeset/106729; thanks, Dan! |