WebGestureEvent can not encode delta and area

• Component: WebKit2
• Status: RESOLVED FIXED

[Allan Sandfeld Jensen]

Scroll-gestures needs a delta field for movement, and Tap-gestures need an area for the touch point. Neither are currently encoded in WebGestureEvent, and WebCore::PlatformGestureEvent lacks area.

[Allan Sandfeld Jensen]

Created attachment 125306 [details]
Patch

[WebKit Review Bot]

Comment on attachment 125306 [details]
Patch

Attachment 125306 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11423230

[Allan Sandfeld Jensen]

Created attachment 125613 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 125613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125613&action=review

> Source/WebCore/ChangeLog:4
> +        Add area field to PlatformGestureEvent.
> +        https://bugs.webkit.org/show_bug.cgi?id=77728

You need to keep this the exact as the bug title

> Source/WebKit2/ChangeLog:4
> +        Support delta and area fields in WebGestureEvent, and send area with Qt tap gesture.
> +        https://bugs.webkit.org/show_bug.cgi?id=77728

Here it is different

[Allan Sandfeld Jensen]

Created attachment 125621 [details]
Patch for landing

Use bug title in ChangeLog.

[WebKit Review Bot]

Comment on attachment 125621 [details]
Patch for landing

Clearing flags on attachment: 125621

Committed r106803: <http://trac.webkit.org/changeset/106803>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.