Bug 77596 – update CSS3 calc() color tests to use pre/post js

• Component: New Bugs
• Status: RESOLVED FIXED

[Mike Lawther]

update CSS3 calc() color tests to use pre/post js

[Mike Lawther]

Created attachment 125067 [details]
Patch

[Daniel Bates]

Comment on attachment 125067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125067&action=review

> LayoutTests/css3/calc/color-hsl.html:5
> +    #simple        { color: hsl(-webkit-calcy(120),-webkit-calc(75%),-webkit-calc(50%)); }

Did you mean to call -webkit-calcy()?

> LayoutTests/css3/calc/color-hsl.html:8
> +    #alpha        { color: hsla(-webkit-calcy(120),-webkit-calc(75%),-webkit-calc(50%), -webkit-calc(0.7)); }

Ditto.

> LayoutTests/css3/calc/color-rgb.html:5
> +    #simple        { color: rgb(-webkit-calcy(10),-webkit-calc(18 * 10),-webkit-calc(30)); }

Ditto.

> LayoutTests/css3/calc/color-rgb.html:7
> +    #percentsimple        { color: rgb(-webkit-calcy(2% + 8%),-webkit-calc(95%),-webkit-calc(3% * 10)); }

Ditto.

> LayoutTests/css3/calc/color-rgb.html:10
> +    #alpha        { color: rgba(-webkit-calcy(10),-webkit-calc(180),-webkit-calc(30), -webkit-calc(0.35 * 2)); }

Ditto.

> LayoutTests/css3/calc/color-rgb.html:12
> +    #percentalpha        { color: rgba(-webkit-calcy(2 * 5%),-webkit-calc(100% - 5%),-webkit-calc(30%),-webkit-calc(0.2 * 3 + 0.1)); }

Ditto.

[Kent Tamura]

Comment on attachment 125067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125067&action=review

> LayoutTests/css3/calc/color-hsl.html:5
> -#simple        {color: hsl(-webkit-calc(120),-webkit-calc(75%),-webkit-calc(50%));}
> +    #controlsimple { color: hsl(120,75%,50%); }
> +    #simple        { color: hsl(-webkit-calcy(120),-webkit-calc(75%),-webkit-calc(50%)); }

I don't like adding indentation to the top-level code.

> LayoutTests/css3/calc/color-hsl.html:21
>  <script>
> -if (window.layoutTestController)
> -    layoutTestController.dumpAsText();
> -
> -tests = ["simple", "alpha"];
> +    description("Tests that CSS3 calc() can be used with the hsl() and hsla() functions");
> +    
> +    tests = ["simple", "alpha"];

ditto.

> LayoutTests/css3/calc/color-rgb.html:4
> +    #controlsimple { color: rgb(10,180,30); }

ditto.

> LayoutTests/css3/calc/color-rgb.html:29
> +    description("Tests that CSS3 calc() can be used with the rgb() and rgba() functions");

ditto.

[Kent Tamura]

Comment on attachment 125067 [details]
Patch

back to r? for Daniel's comment :-)

[Mike Lawther]

Created attachment 125072 [details]
Patch

[Mike Lawther]

Comment on attachment 125067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125067&action=review

>>> LayoutTests/css3/calc/color-hsl.html:5
>>> +    #simple        { color: hsl(-webkit-calcy(120),-webkit-calc(75%),-webkit-calc(50%)); }
>> 
>> Did you mean to call -webkit-calcy()?
> 
> I don't like adding indentation to the top-level code.

Doh! Good catch - fixed.

I've left the indentation as is after a discussion on IRC.

>> LayoutTests/css3/calc/color-hsl.html:8
>> +    #alpha        { color: hsla(-webkit-calcy(120),-webkit-calc(75%),-webkit-calc(50%), -webkit-calc(0.7)); }
> 
> Ditto.

Fixed.

>> LayoutTests/css3/calc/color-hsl.html:21
>> +    tests = ["simple", "alpha"];
> 
> ditto.

Left as per IRC discussion.

>> LayoutTests/css3/calc/color-rgb.html:4
>> +    #controlsimple { color: rgb(10,180,30); }
> 
> ditto.

Left as per IRC discussion.

>> LayoutTests/css3/calc/color-rgb.html:5
>> +    #simple        { color: rgb(-webkit-calcy(10),-webkit-calc(18 * 10),-webkit-calc(30)); }
> 
> Ditto.

Fixed.

>> LayoutTests/css3/calc/color-rgb.html:7
>> +    #percentsimple        { color: rgb(-webkit-calcy(2% + 8%),-webkit-calc(95%),-webkit-calc(3% * 10)); }
> 
> Ditto.

Fixed.

>> LayoutTests/css3/calc/color-rgb.html:10
>> +    #alpha        { color: rgba(-webkit-calcy(10),-webkit-calc(180),-webkit-calc(30), -webkit-calc(0.35 * 2)); }
> 
> Ditto.

Fixed.

>> LayoutTests/css3/calc/color-rgb.html:12
>> +    #percentalpha        { color: rgba(-webkit-calcy(2 * 5%),-webkit-calc(100% - 5%),-webkit-calc(30%),-webkit-calc(0.2 * 3 + 0.1)); }
> 
> Ditto.

Fixed.

>> LayoutTests/css3/calc/color-rgb.html:29
>> +    description("Tests that CSS3 calc() can be used with the rgb() and rgba() functions");
> 
> ditto.

Left as per IRC discussion.

[Kent Tamura]

Comment on attachment 125072 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 125072 [details]
Patch

Attachment 125072 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11394711

New failing tests:
css3/calc/color-hsl.html
css3/calc/color-rgb.html

[Mike Lawther]

The provided link http://queues.webkit.org/results/11394711 doesn't show color-rgb.html or color-hsl.html anywhere. Is this bot flakiness somehow?

[Mike Lawther]

Created attachment 125573 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 125573 [details]
Patch for landing

Rejecting attachment 125573 [details] from commit-queue.

New failing tests:
css3/calc/color-hsl.html
css3/calc/color-rgb.html
Full output: http://queues.webkit.org/results/11434167

[Mike Lawther]

Created attachment 126292 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 126292 [details]
Patch for landing

Clearing flags on attachment: 126292

Committed r107245: <http://trac.webkit.org/changeset/107245>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.