Bug 77589

Summary: Remove [ImplementationUUID] and [InterfaceUUID] from html/canvas/*.idl
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarrin, darin, ojan, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77393    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-02-01 17:48:57 PST
[ImplementationUUID] and [InterfaceUUID] are used in html/canvas/*.idl, but they are not implemented in code generators and thus have no meaning. We can remove them.
Attachments
Patch (4.34 KB, patch)
2012-02-01 17:51 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-01 17:51:19 PST
Created attachment 125054 [details] Patch
Adam Barth
Comment 2 2012-02-01 17:54:26 PST
Comment on attachment 125054 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125054&action=review > Source/WebCore/ChangeLog:10 > + [ImplementationUUID] and [InterfaceUUID] are used in html/canvas/*.idl, > + but they are not implemented in code generators and thus have no meaning. > + This patch removes them. Do we know the history here? Did these attributes mean something at some point? Is the reason for their existence no longer important?
Kentaro Hara
Comment 3 2012-02-01 18:08:04 PST
(In reply to comment #2) > Do we know the history here? Did these attributes mean something at some point? Is the reason for their existence no longer important? Those UUIDs were added in preparation of adding autogeneration of the COM DOM bindings. http://trac.webkit.org/changeset/27276 It appears that those UUIDs had been already removed from almost all IDL files, but they have remained in some IDL files in html/canvas/ unintentionally.
Adam Barth
Comment 4 2012-02-01 18:09:35 PST
Comment on attachment 125054 [details] Patch Makes sense. Thanks.
WebKit Review Bot
Comment 5 2012-02-01 18:48:10 PST
Comment on attachment 125054 [details] Patch Clearing flags on attachment: 125054 Committed r106526: <http://trac.webkit.org/changeset/106526>
WebKit Review Bot
Comment 6 2012-02-01 18:48:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.