Bug 77565

Summary:

rebaseline box-shadow-clipped-slices

Product:

WebKit

Reporter:

epoger

Component:

Tools / Tests

Assignee:

epoger

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

epoger

Reported 2012-02-01 11:22:22 PST

this is a known change due to a Skia deps roll, only affects low-order bits.

Attachments
Patch (21.43 KB, patch) 2012-02-01 11:23 PST, epoger	no flags	Details Formatted Diff Diff
Patch (22.07 KB, patch) 2012-02-01 12:43 PST, epoger	no flags	Details Formatted Diff Diff
Patch (1.29 KB, patch) 2012-02-03 08:31 PST, epoger	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

epoger

Comment 1 2012-02-01 11:23:14 PST

Created attachment 124979 [details] Patch

epoger

Comment 2 2012-02-01 11:24:00 PST

pixel diffs can be best seen at http://www.corp.google.com/~epoger/rebaselines/2012-02-01-11-17-46/rebaseline.html

Stephen White

Comment 3 2012-02-01 11:30:17 PST

Comment on attachment 124979 [details] Patch OK. r=me

WebKit Review Bot

Comment 4 2012-02-01 12:11:32 PST

Comment on attachment 124979 [details] Patch Attachment 124979 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11394524 New failing tests: fast/box-shadow/box-shadow-clipped-slices.html

epoger

Comment 5 2012-02-01 12:25:52 PST

Argh... this fails chromium-ews because the chromium change that modifies these image results hasn't been deps-rolled into WebKit yet. Cary- can you please run this for me to land the change in spite of the commit queue failure? Tools/Scripts/webkit-patch land 77565

epoger

Comment 6 2012-02-01 12:33:27 PST

Cary has convinced me that the cleaner thing to do is for me to add this test to test_expectations so that the buildbots are all green both BEFORE and AFTER the chromium change propagates to webkit. Sigh. Doing that now.

epoger

Comment 7 2012-02-01 12:43:25 PST

Created attachment 124993 [details] Patch

Stephen White

Comment 8 2012-02-01 12:47:05 PST

Comment on attachment 124993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124993&action=review > LayoutTests/platform/chromium/test_expectations.txt:4057 > +// This can be removed once Chromium r120068 has been deps-rolled into Skia. Nit: you probably meant "into WebKit".

epoger

Comment 9 2012-02-01 12:48:23 PST

(In reply to comment #8) > Nit: you probably meant "into WebKit". Oy vey, indeed I did. Hopefully I will be able to kill that line within the next 24 hours anyway. :-)

WebKit Review Bot

Comment 10 2012-02-01 14:03:03 PST

Comment on attachment 124993 [details] Patch Clearing flags on attachment: 124993 Committed r106493: <http://trac.webkit.org/changeset/106493>

WebKit Review Bot

Comment 11 2012-02-01 14:03:07 PST

All reviewed patches have been landed. Closing bug.

epoger

Comment 12 2012-02-03 08:29:39 PST

Reopening to remove that line from test_expectations now that Chromium r120068 has been deps-rolled into WebKit.

epoger

Comment 13 2012-02-03 08:31:42 PST

Created attachment 125338 [details] Patch

WebKit Review Bot

Comment 14 2012-02-03 13:25:49 PST

Comment on attachment 125338 [details] Patch Clearing flags on attachment: 125338 Committed r106689: <http://trac.webkit.org/changeset/106689>

WebKit Review Bot

Comment 15 2012-02-03 13:25:54 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.