Summary: | rebaseline box-shadow-clipped-slices | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | epoger | ||||||||
Component: | Tools / Tests | Assignee: | epoger | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
epoger
2012-02-01 11:22:22 PST
Created attachment 124979 [details]
Patch
pixel diffs can be best seen at http://www.corp.google.com/~epoger/rebaselines/2012-02-01-11-17-46/rebaseline.html Comment on attachment 124979 [details]
Patch
OK. r=me
Comment on attachment 124979 [details] Patch Attachment 124979 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11394524 New failing tests: fast/box-shadow/box-shadow-clipped-slices.html Argh... this fails chromium-ews because the chromium change that modifies these image results hasn't been deps-rolled into WebKit yet. Cary- can you please run this for me to land the change in spite of the commit queue failure? Tools/Scripts/webkit-patch land 77565 Cary has convinced me that the cleaner thing to do is for me to add this test to test_expectations so that the buildbots are all green both BEFORE and AFTER the chromium change propagates to webkit. Sigh. Doing that now. Created attachment 124993 [details]
Patch
Comment on attachment 124993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124993&action=review > LayoutTests/platform/chromium/test_expectations.txt:4057 > +// This can be removed once Chromium r120068 has been deps-rolled into Skia. Nit: you probably meant "into WebKit". (In reply to comment #8) > Nit: you probably meant "into WebKit". Oy vey, indeed I did. Hopefully I will be able to kill that line within the next 24 hours anyway. :-) Comment on attachment 124993 [details] Patch Clearing flags on attachment: 124993 Committed r106493: <http://trac.webkit.org/changeset/106493> All reviewed patches have been landed. Closing bug. Reopening to remove that line from test_expectations now that Chromium r120068 has been deps-rolled into WebKit. Created attachment 125338 [details]
Patch
Comment on attachment 125338 [details] Patch Clearing flags on attachment: 125338 Committed r106689: <http://trac.webkit.org/changeset/106689> All reviewed patches have been landed. Closing bug. |