Bug 77565

Summary: rebaseline box-shadow-clipped-slices
Product: WebKit Reporter: epoger
Component: Tools / TestsAssignee: epoger
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description epoger 2012-02-01 11:22:22 PST
this is a known change due to a Skia deps roll, only affects low-order bits.
Comment 1 epoger 2012-02-01 11:23:14 PST
Created attachment 124979 [details]
Patch
Comment 2 epoger 2012-02-01 11:24:00 PST
pixel diffs can be best seen at http://www.corp.google.com/~epoger/rebaselines/2012-02-01-11-17-46/rebaseline.html
Comment 3 Stephen White 2012-02-01 11:30:17 PST
Comment on attachment 124979 [details]
Patch

OK.  r=me
Comment 4 WebKit Review Bot 2012-02-01 12:11:32 PST
Comment on attachment 124979 [details]
Patch

Attachment 124979 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11394524

New failing tests:
fast/box-shadow/box-shadow-clipped-slices.html
Comment 5 epoger 2012-02-01 12:25:52 PST
Argh... this fails chromium-ews because the chromium change that modifies these image results hasn't been deps-rolled into WebKit yet.

Cary- can you please run this for me to land the change in spite of the commit queue failure?
Tools/Scripts/webkit-patch land 77565
Comment 6 epoger 2012-02-01 12:33:27 PST
Cary has convinced me that the cleaner thing to do is for me to add this test to test_expectations so that the buildbots are all green both BEFORE and AFTER the chromium change propagates to webkit.

Sigh.  Doing that now.
Comment 7 epoger 2012-02-01 12:43:25 PST
Created attachment 124993 [details]
Patch
Comment 8 Stephen White 2012-02-01 12:47:05 PST
Comment on attachment 124993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124993&action=review

> LayoutTests/platform/chromium/test_expectations.txt:4057
> +// This can be removed once Chromium r120068 has been deps-rolled into Skia.

Nit:  you probably meant "into WebKit".
Comment 9 epoger 2012-02-01 12:48:23 PST
(In reply to comment #8)
> Nit:  you probably meant "into WebKit".

Oy vey, indeed I did.  Hopefully I will be able to kill that line within the next 24 hours anyway. :-)
Comment 10 WebKit Review Bot 2012-02-01 14:03:03 PST
Comment on attachment 124993 [details]
Patch

Clearing flags on attachment: 124993

Committed r106493: <http://trac.webkit.org/changeset/106493>
Comment 11 WebKit Review Bot 2012-02-01 14:03:07 PST
All reviewed patches have been landed.  Closing bug.
Comment 12 epoger 2012-02-03 08:29:39 PST
Reopening to remove that line from test_expectations now that Chromium r120068 has been deps-rolled into WebKit.
Comment 13 epoger 2012-02-03 08:31:42 PST
Created attachment 125338 [details]
Patch
Comment 14 WebKit Review Bot 2012-02-03 13:25:49 PST
Comment on attachment 125338 [details]
Patch

Clearing flags on attachment: 125338

Committed r106689: <http://trac.webkit.org/changeset/106689>
Comment 15 WebKit Review Bot 2012-02-03 13:25:54 PST
All reviewed patches have been landed.  Closing bug.