Bug 77548

Summary: Web Inspector: debugger reports wrong sources when paused in inline script on page reload
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Test page
none
Patch
none
Patch vsevik: review+

Description Yury Semikhatsky 2012-02-01 05:52:52 PST
1. Open attached file.
2. Open inspector.
3. Reload the page.

Result:
When clicking on call frames wrong source line is revealed.
Comment 1 Yury Semikhatsky 2012-02-01 06:02:41 PST
Created attachment 124939 [details]
Test page
Comment 2 Yury Semikhatsky 2012-02-01 08:27:11 PST
Created attachment 124953 [details]
Patch
Comment 3 Yury Semikhatsky 2012-02-01 08:38:54 PST
Created attachment 124956 [details]
Patch
Comment 4 Yury Semikhatsky 2012-02-01 09:03:40 PST
Committed r106468: <http://trac.webkit.org/changeset/106468>
Comment 5 Pavel Podivilov 2012-02-01 09:05:13 PST
Comment on attachment 124956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124956&action=review

Looks good!

> Source/WebCore/bindings/v8/DebuggerScript.js:95
> +        endLine += 1;

nit: Consider adding 1 to lineCount instead to match the comment.