Summary: | [Qt][WK2] Loading cuttherope.ie results in segfault | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||
Component: | WebKit2 | Assignee: | zalan <zalan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | menard, webkit.review.bot, zoltan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
URL: | http://cuttherope.ie | ||||||
Attachments: |
|
Description
zalan
2012-02-01 05:20:11 PST
ShareableBitmap lacks an additional ref() when (Qt)ShareableBitmap::createImage() is called. ShareableBitmap gets destroyed early because of this missing ref. Both Cairo and CG have this ref(), which is balanced at when the associated (shared) data is being freed. see ShareableBitmap::createCairoSurface(). Fix: QImage c'tor needs a callback function parameter, which gets called when the associated data is being freed. It enables Qt's ShareableBitmap to introduce ref()/deref() pair similar to Cairo/CG. Created attachment 126749 [details]
Patch
Comment on attachment 126749 [details] Patch Clearing flags on attachment: 126749 Committed r107571: <http://trac.webkit.org/changeset/107571> All reviewed patches have been landed. Closing bug. |