Summary: | [GTK] unittests/testloading crashes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | svillar, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Philippe Normand
2012-02-01 04:34:37 PST
Created attachment 124929 [details]
Patch
Attachment 124929 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1053: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 124929 [details]
Patch
OK.
Comment on attachment 124929 [details] Patch Clearing flags on attachment: 124929 Committed r106467: <http://trac.webkit.org/changeset/106467> All reviewed patches have been landed. Closing bug. |