| Summary: | IndexedDB: mark quota layout test WONTFIX | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Grogan <dgrogan> | ||||||||||||
| Component: | New Bugs | Assignee: | David Grogan <dgrogan> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | jsbell, tony, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
David Grogan
2012-01-31 11:18:00 PST
Created attachment 124780 [details]
Patch
Attachment 124780 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9
Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.
When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".
rebase refs/remotes/origin/master: command returned error: 1
Died at Tools/Scripts/update-webkit line 164.
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 124783 [details]
Patch
Comment on attachment 124783 [details]
Patch
What about database-quota-expected.txt?
Created attachment 124784 [details]
Patch
Attachment 124783 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource From git://git.webkit.org/WebKit 35bf539..c00f0a0 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 106372 = 35bf53917ffea9b99274893b132819d2a8add71f r106373 = c00f0a0c31f2721d2fb62ca757c315e016c7c7b5 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Auto-merging Source/WebCore/WebCore.exp.in Auto-merging Source/WebKit/mac/ChangeLog CONFLICT (content): Merge conflict in Source/WebKit/mac/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style. Attachment 124784 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9
Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Auto-merging Source/WebCore/WebCore.exp.in
Auto-merging Source/WebKit/mac/ChangeLog
CONFLICT (content): Merge conflict in Source/WebKit/mac/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.
When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".
rebase refs/remotes/origin/master: command returned error: 1
Died at Tools/Scripts/update-webkit line 164.
If any of these errors are false positives, please file a bug against check-webkit-style.
Now also deleted database-quota-expected.txt Comment on attachment 124784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124784&action=review lgtm > LayoutTests/ChangeLog:13 > + Nit: should list storage/indexeddb/database-quota-expected.txt (doesn't get added automagically, does it?) Created attachment 124795 [details]
Patch
Tony, could you review this?
> Nit: should list storage/indexeddb/database-quota-expected.txt (doesn't get added automagically, does it?)
Updated.
Comment on attachment 124795 [details]
Patch
Is this test always going to fail in Chromium DRT? Would it be worth keeping this test around for other ports that want to implement indexeddb?
(In reply to comment #12) > (From update of attachment 124795 [details]) > Is this test always going to fail in Chromium DRT? Yep. > Would it be worth keeping this test around for other ports that want to implement indexeddb? Probably not, quota isn't in the indexeddb api and no indexeddb quota code is in webkit/webcore. If another port implements quotas it'll also be in the embedder and embedder-specific. (In reply to comment #13) > (In reply to comment #12) > > Would it be worth keeping this test around for other ports that want to implement indexeddb? > > Probably not, quota isn't in the indexeddb api and no indexeddb quota code is in webkit/webcore. If another port implements quotas it'll also be in the embedder and embedder-specific. Is the quota size in the spec? Is the exception behavior in the spec? Even though the quota code isn't in webkit/webcore and Chromium doesn't pass it, it would still be good to have a layout test. There are plenty of tests that depend on stuff implemented outside of webkit/webcore (e.g., network behaviors, video/audio playback behaviors, graphic behaviors, etc). We should probably just mark the bug as WONTFIX with a comment saying that it's tested elsewhere. (In reply to comment #14) > (In reply to comment #13) > > (In reply to comment #12) > > > Would it be worth keeping this test around for other ports that want to implement indexeddb? > > > > Probably not, quota isn't in the indexeddb api and no indexeddb quota code is in webkit/webcore. If another port implements quotas it'll also be in the embedder and embedder-specific. > > Is the quota size in the spec? No. > Is the exception behavior in the spec? Kind of - quota errors are used in examples of how an implementation-specific error might propagate. > Even though the quota code isn't in webkit/webcore and Chromium doesn't pass it, it would still be good to have a layout test. There are plenty of tests that depend on stuff implemented outside of webkit/webcore (e.g., network behaviors, video/audio playback behaviors, graphic behaviors, etc). > > We should probably just mark the bug as WONTFIX with a comment saying that it's tested elsewhere. SG. (In reply to comment #15) > (In reply to comment #14) > > We should probably just mark the bug as WONTFIX with a comment saying that it's tested elsewhere. > > SG. Sorry, I meant to say we should mark the test as WONTFIX (there are other examples of this in the test_expectations.txt file). Reopening for a patch that marks database-quota.html WONTFIX. Created attachment 125430 [details]
Patch
Comment on attachment 125430 [details]
Patch
Thanks! Sorry for the confusion.
Comment on attachment 125430 [details] Patch Clearing flags on attachment: 125430 Committed r106733: <http://trac.webkit.org/changeset/106733> All reviewed patches have been landed. Closing bug. |