Bug 77446

Summary: [CSSRegions]Reduce the cases when the box style in region is computed
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch none

Description Mihnea Ovidenie 2012-01-31 09:10:22 PST
Box style in regions should be computed only when the region has region styling rules.
Comment 1 Mihnea Ovidenie 2012-01-31 09:14:49 PST
Created attachment 124756 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-31 09:17:36 PST
Attachment 124756 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2012-01-31 11:00:31 PST
Comment on attachment 124756 [details]
Patch

r=me
Comment 4 WebKit Review Bot 2012-01-31 14:55:17 PST
Comment on attachment 124756 [details]
Patch

Clearing flags on attachment: 124756

Committed r106398: <http://trac.webkit.org/changeset/106398>
Comment 5 WebKit Review Bot 2012-01-31 14:55:21 PST
All reviewed patches have been landed.  Closing bug.