Summary: | WebCore build exceeds address space on 32-bit Windows builders (again) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jessie Berlin <jberlin> | ||||
Component: | WebCore Misc. | Assignee: | Jessie Berlin <jberlin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, jberlin, jhoneycutt, lforschler, sfalken | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | Windows 7 | ||||||
Attachments: |
|
Description
Jessie Berlin
2012-01-30 12:14:47 PST
Created attachment 124583 [details]
Patch
Comment on attachment 124583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124583&action=review > Source/WebCore/ChangeLog:9 > + Add an Inspector All-In-One file, but only use it in Release and Production builds to make > + it possible to debug in the Debug configuration (the symbols will be in the correct .o file I think you mean .obj, not .o. It's probably worth mentioning that this is different from our other AllInOne.cpp files, but we think this new way is better. > Source/WebCore/inspector/InspectorAllInOne.cpp:2 > + * Copyright (C) 2011 Apple Inc. All rights reserved. It's 2012! (In reply to comment #2) > (From update of attachment 124583 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=124583&action=review > > > Source/WebCore/ChangeLog:9 > > + Add an Inspector All-In-One file, but only use it in Release and Production builds to make > > + it possible to debug in the Debug configuration (the symbols will be in the correct .o file > > I think you mean .obj, not .o. Yes, fixed. > It's probably worth mentioning that this is different from our other AllInOne.cpp files, but we think this new way is better. Changed to: Add an Inspector All-In-One file, but only use it in Release and Production builds. This differs from our other All-In-One files, but it is a better approach because it makes debugging possible in the Debug configuration (the symbols will be in the correct .obj file for the original .cpp files). > > > Source/WebCore/inspector/InspectorAllInOne.cpp:2 > > + * Copyright (C) 2011 Apple Inc. All rights reserved. > > It's 2012! Whoops! Fixed. Thanks for the review :) Comment on attachment 124583 [details] Patch Committed in http://trac.webkit.org/changeset/106280. |