Bug 77349 – Track the NPN protocol version negotiated with the server

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[raman tenneti]

This is part of measuring effectiveness of SPDY; Track the protocol version (http/1.1, spdy/2 or spdy/2.1 or ...) which was negotiated with the server using TSL/NPN mechanism. chrome:loadtimes will display the protocol version that is negotiated.

[raman tenneti]

Created attachment 124624 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[raman tenneti]

Comment on attachment 124624 [details]
Patch

Hi Darin,
  We wanted to add support in chrome:loadtimes to print the NPN protocol that was negotiated (servers could decide which SPDY protocol they would like to use - either SPDY/2 or SPDY/2.1. We would like to log the protocol server and client have negotiated). 

Would appreciate your comments.

thanks
raman

[Darin Fisher (:fishd, Google)]

Comment on attachment 124624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124624&action=review

> Source/WebKit/chromium/public/platform/WebURLResponse.h:151
> +    WEBKIT_EXPORT WebCString protocolVersion() const;

this field and the NpnNegotiated field don't really belong in webkit.  you are adding
this one here just as plumbing.  the same was true when NpnNegotiated was added.

since then, we have developed a way to attach opaque extra data to a WebURLRequest
(and underlying ResourceRequest).  can you use that instead?

see WebURLRequest::setExtraData.

On the chromium side, look at RenderViewImpl::willSendRequest to see where
setExtraData is called.

it would be great if you could move NpnNegotiated too! :-)

[raman tenneti]

> since then, we have developed a way to attach opaque extra data to a
> WebURLRequest (and underlying ResourceRequest).  can you use that instead?

The above is awesome. Will make the above changes and will resubmit it for review.

thanks much,
raman

[raman tenneti]

Created attachment 127618 [details]
patch to add extra data to WebURLResponse

Hi Darin,
  I am really sorry for the delay in uploading this change. Would appreciate if you could take a look at this patch.

thanks very much,
raman

[raman tenneti]

Comment on attachment 127618 [details]
patch to add extra data to WebURLResponse

Will upload the patch using proper webkit procedure. Deleting this patch. Sorry about that.

[raman tenneti]

Created attachment 127683 [details]
Patch

[WebKit Review Bot]

Comment on attachment 127683 [details]
Patch

Clearing flags on attachment: 127683

Committed r108184: <http://trac.webkit.org/changeset/108184>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.