Bug 77312

Summary: BMW Car Configuration Page doesn't work (Only manifests in Chromium)
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: rjkroege, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Needs tests
none
Patch none

Adam Barth
Reported 2012-01-29 19:15:18 PST
BMW Car Configuration Page doesn't work (Only manifests in Chromium)
Attachments
Needs tests (3.42 KB, patch)
2012-01-29 19:16 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (4.46 KB, patch)
2012-01-31 16:56 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-01-29 19:16:25 PST
Created attachment 124485 [details] Needs tests
Adam Barth
Comment 2 2012-01-30 15:51:59 PST
Comment on attachment 124485 [details] Needs tests I'm nominating this for review even though it doesn't have tests. I'm happy to add tests if someone knows how we test other RuntimeEnabledFeatures flags. I poked around a bit and I didn't find anything.
Eric Seidel (no email)
Comment 3 2012-01-30 16:04:05 PST
Comment on attachment 124485 [details] Needs tests So we certainly need a bug about making RuntimeEnabledFeatures testable in DRT, and ideally we'd have a patch for such a bug before landing this. But I'm also willing to approve this patch as-is. But I'd rather have a test. We already have testing for Settings using layoutTestController.overridePreference.
Adam Barth
Comment 4 2012-01-30 16:09:33 PST
I've created a bug for adding a testing framework for RuntimeEnabledFeatures and assigned it to myself: https://bugs.webkit.org/show_bug.cgi?id=77379
Adam Barth
Comment 5 2012-01-31 16:56:59 PST
Created attachment 124853 [details] Patch
WebKit Review Bot
Comment 6 2012-02-02 16:26:25 PST
Comment on attachment 124853 [details] Patch Clearing flags on attachment: 124853 Committed r106603: <http://trac.webkit.org/changeset/106603>
WebKit Review Bot
Comment 7 2012-02-02 16:26:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.