Bug 77312

Summary: BMW Car Configuration Page doesn't work (Only manifests in Chromium)
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Severity: Normal CC: rjkroege, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Needs tests
Patch none

Description Adam Barth 2012-01-29 19:15:18 PST
BMW Car Configuration Page doesn't work (Only manifests in Chromium)
Comment 1 Adam Barth 2012-01-29 19:16:25 PST
Created attachment 124485 [details]
Needs tests
Comment 2 Adam Barth 2012-01-30 15:51:59 PST
Comment on attachment 124485 [details]
Needs tests

I'm nominating this for review even though it doesn't have tests.  I'm happy to add tests if someone knows how we test other RuntimeEnabledFeatures flags.  I poked around a bit and I didn't find anything.
Comment 3 Eric Seidel (no email) 2012-01-30 16:04:05 PST
Comment on attachment 124485 [details]
Needs tests

So we certainly need a bug about making RuntimeEnabledFeatures testable in DRT, and ideally we'd have a patch for such a bug before landing this.  But I'm also willing to approve this patch as-is.  But I'd rather have a test.  We already have testing for Settings using layoutTestController.overridePreference.
Comment 4 Adam Barth 2012-01-30 16:09:33 PST
I've created a bug for adding a testing framework for RuntimeEnabledFeatures and assigned it to myself:
Comment 5 Adam Barth 2012-01-31 16:56:59 PST
Created attachment 124853 [details]
Comment 6 WebKit Review Bot 2012-02-02 16:26:25 PST
Comment on attachment 124853 [details]

Clearing flags on attachment: 124853

Committed r106603: <http://trac.webkit.org/changeset/106603>
Comment 7 WebKit Review Bot 2012-02-02 16:26:29 PST
All reviewed patches have been landed.  Closing bug.