Bug 77254

Summary: Prepare WebCore.gyp for ffmpeg source transition.
Product: WebKit Reporter: Dale Curtis <dalecurtis>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, scherkus, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Dale Curtis
Reported 2012-01-27 15:44:50 PST
Prepare WebCore.gyp for ffmpeg source transition.
Attachments
Patch (1.60 KB, patch)
2012-01-27 15:47 PST, Dale Curtis 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.60 KB, patch)
2012-01-29 18:29 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dale Curtis
Comment 1 2012-01-27 15:47:27 PST
Created attachment 124386 [details] Patch
Dale Curtis
Comment 2 2012-01-27 15:51:13 PST
scherkus: Who is a good reviewer for this? Chromium try bots are in progress. Is there anything else to check?
Dale Curtis
Comment 3 2012-01-27 17:47:53 PST
abarth: I noticed you've changed the WebCore.gyp file the most in recent history, can you please take a look at this? Chrome Linux/Mac/Win Trybots all passed compile.
Adam Barth
Comment 4 2012-01-28 00:20:50 PST
Tony or dpranke is probably your best reviewer.
Tony Chang
Comment 5 2012-01-29 18:27:03 PST
Comment on attachment 124386 [details] Patch I would drop the trailing slash since we don't normally append it on include dirs.
Tony Chang
Comment 6 2012-01-29 18:29:32 PST
Created attachment 124482 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-01-29 19:49:32 PST
Comment on attachment 124482 [details] Patch for landing Clearing flags on attachment: 124482 Committed r106209: <http://trac.webkit.org/changeset/106209>
WebKit Review Bot
Comment 8 2012-01-29 19:49:37 PST
All reviewed patches have been landed. Closing bug.
Dale Curtis
Comment 9 2012-01-30 12:30:43 PST
Thanks for the review and nit fix Tony!
Note You need to log in before you can comment on or make changes to this bug.