Bug 77212

Summary: [Qt] Spurious resize events from frameviews using fixed layout
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Layout and RenderingAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Allan Sandfeld Jensen 2012-01-27 06:55:14 PST
When using a frame with fixed layout size, like Qt WebKit2 in touch mode, resize events are send every time the content resizes.

The problems seems to be that the widget has the size of the document, and resize events are send when widget size changes.

The solution should be simply to use the layout size instead of the widget size for determining if resize events should be send.
Comment 1 Allan Sandfeld Jensen 2012-01-27 07:43:28 PST
Created attachment 124316 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-01-27 07:47:03 PST
Comment on attachment 124316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124316&action=review

> ChangeLog:9
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * ManualTests/resize-events.html: Added.
> +

A comment why a layout test wasnt possible would have been good

> ManualTests/resize-events.html:33
> +            // 0 or 1 resize events are acceptable, more is not

Why not write this in the HTML, now it is a manual test? You could even make it write SUCCESS/FAIL
Comment 3 Allan Sandfeld Jensen 2012-01-30 01:27:13 PST
Created attachment 124507 [details]
Patch
Comment 4 Kenneth Rohde Christiansen 2012-01-30 01:34:13 PST
Comment on attachment 124507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124507&action=review

> ManualTests/resize-events.html:17
> +        Test who many resize events are emitted during page load and dynamic content generation.

how*
Comment 5 Allan Sandfeld Jensen 2012-01-30 02:00:40 PST
Created attachment 124513 [details]
Patch
Comment 6 WebKit Review Bot 2012-01-30 04:36:54 PST
Comment on attachment 124513 [details]
Patch

Clearing flags on attachment: 124513

Committed r106232: <http://trac.webkit.org/changeset/106232>
Comment 7 WebKit Review Bot 2012-01-30 04:36:58 PST
All reviewed patches have been landed.  Closing bug.