Bug 77199

Summary: Web Inspector: show memory sizes in bytes in heap profiler
Product: WebKit Reporter: Alexei Filippov <alph>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 78411    
Attachments:
Description Flags
Patch
none
Patch none

Description Alexei Filippov 2012-01-27 03:45:06 PST 
Show allocated sizes in bytes instead of KB and MB as it makes it easier to compare numbers.
Comment 1 Alexei Filippov 2012-01-27 04:50:13 PST 
Created attachment 124290 [details]
Patch
Comment 2 Pavel Feldman 2012-01-27 06:33:09 PST 
Comment on attachment 124290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124290&action=review

> Source/WebCore/inspector/front-end/UIUtils.js:449
> +    while (str.match(re)) {

nit: no need for { } here.
Comment 3 Alexei Filippov 2012-01-31 02:58:06 PST 
Created attachment 124695 [details]
Patch
Comment 4 WebKit Review Bot 2012-01-31 03:00:48 PST 
Attachment 124695 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Review Bot 2012-01-31 04:11:50 PST 
Comment on attachment 124695 [details]
Patch

Clearing flags on attachment: 124695

Committed r106354: <http://trac.webkit.org/changeset/106354>
Comment 6 WebKit Review Bot 2012-01-31 04:11:55 PST 
All reviewed patches have been landed.  Closing bug.