Bug 77199

Summary: Web Inspector: show memory sizes in bytes in heap profiler
Product: WebKit Reporter: Alexei Filippov <alph>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 78411    
Attachments:
Description Flags
Patch
none
Patch none

Alexei Filippov
Reported 2012-01-27 03:45:06 PST
Show allocated sizes in bytes instead of KB and MB as it makes it easier to compare numbers.
Attachments
Patch (5.63 KB, patch)
2012-01-27 04:50 PST, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Patch (5.62 KB, patch)
2012-01-31 02:58 PST, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexei Filippov
Comment 1 2012-01-27 04:50:13 PST
Created attachment 124290 [details] Patch
Pavel Feldman
Comment 2 2012-01-27 06:33:09 PST
Comment on attachment 124290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124290&action=review > Source/WebCore/inspector/front-end/UIUtils.js:449 > + while (str.match(re)) { nit: no need for { } here.
Alexei Filippov
Comment 3 2012-01-31 02:58:06 PST
Created attachment 124695 [details] Patch
WebKit Review Bot
Comment 4 2012-01-31 03:00:48 PST
Attachment 124695 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 5 2012-01-31 04:11:50 PST
Comment on attachment 124695 [details] Patch Clearing flags on attachment: 124695 Committed r106354: <http://trac.webkit.org/changeset/106354>
WebKit Review Bot
Comment 6 2012-01-31 04:11:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.