Bug 77185

Summary: ImageBuffer::draw should deep copy if drawing to an accelerated context
Product: WebKit Reporter: Matthew Delaney <mdelaney7>
Component: CanvasAssignee: Matthew Delaney <mdelaney7>
Status: RESOLVED FIXED    
Severity: Normal CC: mdelaney7, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=192471
Attachments:
Description Flags
Patch simon.fraser: review+

Matthew Delaney
Reported 2012-01-26 22:08:13 PST
Currently, ImageBuffer::draw shallow copies itself when it's unaccelerated by wrapping its data provider bits in a CGImage. However, the CG API requires that those bits don't change before it gets a chance to draw with them which is something ImageBuffer very much doesn't guarantee since it's basically intended for the exact opposite purpose. Thus, especially in the case of accelerated canvas there can be image tearing so we need to always do a deep copy if the destination context is accelerated. Unfortunately, due to the nature of this issue it's hard to make any non-flaky test, however the code fix is simple and safe as it was our old path before the shallow copy optimization was introduced.
Attachments
Patch (3.30 KB, patch)
2012-01-26 22:24 PST, Matthew Delaney 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matthew Delaney
Comment 1 2012-01-26 22:24:16 PST
Created attachment 124261 [details] Patch
Matthew Delaney
Comment 2 2012-01-26 23:23:28 PST
Committed r106095: <http://trac.webkit.org/changeset/106095>
Note You need to log in before you can comment on or make changes to this bug.