Summary: | Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Filip Pizlo
2012-01-26 19:53:47 PST
Created attachment 124242 [details]
the patch
Created attachment 124244 [details]
the patch
Forgot about one implicit use of $_.
Comment on attachment 124244 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=124244&action=review > Tools/ChangeLog:3 > + Tools/Scripts/change-log-editor is broken due to $_ getting clobbered change-log-editor -> commit-log-editor > Tools/Scripts/commit-log-editor:136 > while (<LOG>) { > + my $curLine = $_; You could do while (my $curLine = <LOG>) { > Tools/Scripts/commit-log-editor:145 > + if (!isGit() || $curLine =~ /^#/) { # Could remove this EOL comment while you're here. Landed in http://trac.webkit.org/changeset/106082 |