Bug 77177

Summary: Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch
none
the patch jhoneycutt: review+

Filip Pizlo
Reported 2012-01-26 19:53:47 PST
Probably should not be relying on $_ not being clobbered in such a large loop body in the first place.
Attachments
the patch (2.18 KB, patch)
2012-01-26 19:55 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (2.19 KB, patch)
2012-01-26 19:56 PST, Filip Pizlo 		jhoneycutt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-01-26 19:55:09 PST
Created attachment 124242 [details] the patch
Filip Pizlo
Comment 2 2012-01-26 19:56:54 PST
Created attachment 124244 [details] the patch Forgot about one implicit use of $_.
Jon Honeycutt
Comment 3 2012-01-26 20:06:52 PST
Comment on attachment 124244 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=124244&action=review > Tools/ChangeLog:3 > + Tools/Scripts/change-log-editor is broken due to $_ getting clobbered change-log-editor -> commit-log-editor > Tools/Scripts/commit-log-editor:136 > while (<LOG>) { > + my $curLine = $_; You could do while (my $curLine = <LOG>) { > Tools/Scripts/commit-log-editor:145 > + if (!isGit() || $curLine =~ /^#/) { # Could remove this EOL comment while you're here.
Filip Pizlo
Comment 4 2012-01-26 20:11:24 PST
Landed in http://trac.webkit.org/changeset/106082
Note You need to log in before you can comment on or make changes to this bug.