Bug 77160

Summary: SchemeRegistry scheme registration is racey
Product: WebKit Reporter: Cris Neckar <cdn>
Component: WebCore Misc.Assignee: Cris Neckar <cdn>
Status: REOPENED    
Severity: Normal CC: abarth, ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Cris Neckar
Reported 2012-01-26 16:24:57 PST
Scheme registration within SchemeRegistry should only be able to occur from the main thread as pointed out by ap@ on https://bugs.webkit.org/show_bug.cgi?id=77041. Currently this is not enforced and in some cases this may cause a race. We should fix this and add asserts (as AP suggested) to all of the scheme registries.
Attachments
Patch (1.40 KB, patch)
2012-01-26 16:44 PST, Cris Neckar 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cris Neckar
Comment 1 2012-01-26 16:44:27 PST
Created attachment 124213 [details] Patch
Adam Barth
Comment 2 2012-01-26 16:46:30 PST
Comment on attachment 124213 [details] Patch WebKit usually prefers links to bugs rather than parenthetical comments. (We're lazy that way.)
Cris Neckar
Comment 3 2012-01-26 16:54:43 PST
Committed r106064: <http://trac.webkit.org/changeset/106064>
Cris Neckar
Comment 4 2012-01-26 16:57:42 PST
This patch was just to remove the assert and add a fixme
Alexey Proskuryakov
Comment 5 2013-03-16 22:54:30 PDT
Comment on attachment 124213 [details] Patch Clearing r+ flag from a landed patch, so that this doesn't show up in commit queue.
Note You need to log in before you can comment on or make changes to this bug.