If the QTDIR environment variable is set, the build system fails to compile WinCairo

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Delaune]

Hi,

When the environment variable QTDIR is defined the build system fails to compile the WinCairo branch. The problem is in the perl module:

WebKit\Tools\Scripts\webkitdirs.pm

The sub determineIsQt() function contains the line:  $isQt = defined($ENV{'QTDIR'});

It could easily be fixed by adding a check for isWinCairo()

Best Wishes,
-David Delaune

[Csaba Osztrogonác]

Created attachment 124522 [details]
Patch

[Daniel Bates]

Comment on attachment 124522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124522&action=review

> Tools/Scripts/webkitdirs.pm:882
>      # The presence of QTDIR only means Qt if --gtk or --wx or --efl or --blackberry or --chromium are not on the command-line

This comment should be updated to mention that we ignore the QTDIR environment variable when --wincairo is specified on the command line.

On another note, this exclusion list of ports is long. Maybe we should consider only building for Qt when the --qt command line option is explicitly specified. That is, don't check for a set QTDIR environment variable.

[Csaba Osztrogonác]

(In reply to comment #2)
> (From update of attachment 124522 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124522&action=review
> 
> > Tools/Scripts/webkitdirs.pm:882
> >      # The presence of QTDIR only means Qt if --gtk or --wx or --efl or --blackberry or --chromium are not on the command-line
> 
> This comment should be updated to mention that we ignore the QTDIR environment variable when --wincairo is specified on the command line.

Good point, fixed.

> On another note, this exclusion list of ports is long. Maybe we should consider only building for Qt when the --qt command line option is explicitly specified. That is, don't check for a set QTDIR environment variable.

I agree with you more or less ...

But in my opinion requiring from developer to use explicit --qt for build-webkit, run-javascriptcore-tests, run-webkit-tests isn't a good idea.

What do you think if we add an evironment for example DEFAULT_WEBKIT_PLATFORM, and developers can define a default platform on they work, but can be overriden with command line options: --gtk, --efl, ...

I think it can be useful for all WebKit developer.

[Csaba Osztrogonác]

I think with this change we can expect that the developer set DEFAULT_WEBKIT_PLATFORM or add platform explicitly.

[Csaba Osztrogonác]

Comment on attachment 124522 [details]
Patch

Landed in http://trac.webkit.org/changeset/106363 with fixed comment.

[Daniel Bates]

(In reply to comment #3)
> (In reply to comment #2)
> [...]
> What do you think if we add an evironment for example DEFAULT_WEBKIT_PLATFORM, and developers can define a default platform on they work, but can be overriden with command line options: --gtk, --efl, ...
>

I don't have a strong opinion on this at this time.  Maybe other people have an opinion on this.