Bug 77062

Summary:

Web Inspector: CodeGeneratorInspector.py: clean InspectorBackendDispatcher.h

Product:

WebKit

Reporter:

Peter Rybin <prybin>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, prybin, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

72861

Attachments:

Description	Flags
Patch	none
original cpp	none
original h	none
new cpp	none
new h	none
Patch	none

Peter Rybin

Reported 2012-01-25 17:10:51 PST

Remove private method from header file, add formal interfaces to domain agents (now called "CommandHandler").

Attachments
Patch (27.71 KB, patch) 2012-01-25 17:16 PST, Peter Rybin	no flags	Details Formatted Diff Diff
original cpp (166.95 KB, text/plain) 2012-01-25 17:19 PST, Peter Rybin	no flags	Details
original h (26.50 KB, text/plain) 2012-01-25 17:19 PST, Peter Rybin	no flags	Details
new cpp (188.25 KB, text/plain) 2012-01-25 17:22 PST, Peter Rybin	no flags	Details
new h (26.37 KB, text/plain) 2012-01-25 17:23 PST, Peter Rybin	no flags	Details
Patch (28.06 KB, patch) 2012-01-27 09:13 PST, Peter Rybin	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Peter Rybin

Comment 1 2012-01-25 17:16:42 PST

Created attachment 124040 [details] Patch

Peter Rybin

Comment 2 2012-01-25 17:19:30 PST

Created attachment 124042 [details] original cpp

Peter Rybin

Comment 3 2012-01-25 17:19:51 PST

Created attachment 124043 [details] original h

Peter Rybin

Comment 4 2012-01-25 17:22:48 PST

Created attachment 124044 [details] new cpp

Peter Rybin

Comment 5 2012-01-25 17:23:14 PST

Created attachment 124045 [details] new h

Yury Semikhatsky

Comment 6 2012-01-27 01:32:58 PST

The change looks good, but please add a meaningful description of the changes made in this patch to the ChangeLog including introduction of *CommandHandler interfaces and why we need InspectorBackendDispatcher to be an abstract interface. Are we going to have alternative implementation of the dispatcher?

Peter Rybin

Comment 7 2012-01-27 09:13:05 PST

Created attachment 124327 [details] Patch

Yury Semikhatsky

Comment 8 2012-01-30 00:57:39 PST

Comment on attachment 124327 [details] Patch Clearing flags on attachment: 124327 Committed r106218: <http://trac.webkit.org/changeset/106218>

Yury Semikhatsky

Comment 9 2012-01-30 00:57:55 PST

All reviewed patches have been landed. Closing bug.

Yury Semikhatsky

Comment 10 2012-01-30 01:44:23 PST

Clang build failed after landing the patch: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac%20Builder%20%28dbg%29/builds/18464/steps/compile/logs/stdio I tried to fix it: http://trac.webkit.org/changeset/106221

Note You need to log in before you can comment on or make changes to this bug.