Bug 77062

Summary: Web Inspector: CodeGeneratorInspector.py: clean InspectorBackendDispatcher.h
Product: WebKit Reporter: Peter Rybin <prybin>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, prybin, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 72861    
Attachments:
Description Flags
Patch
none
original cpp
none
original h
none
new cpp
none
new h
none
Patch none

Description Peter Rybin 2012-01-25 17:10:51 PST 
Remove private method from header file, add formal interfaces to domain agents (now called "CommandHandler").
Comment 1 Peter Rybin 2012-01-25 17:16:42 PST 
Created attachment 124040 [details]
Patch
Comment 2 Peter Rybin 2012-01-25 17:19:30 PST 
Created attachment 124042 [details]
original cpp
Comment 3 Peter Rybin 2012-01-25 17:19:51 PST 
Created attachment 124043 [details]
original h
Comment 4 Peter Rybin 2012-01-25 17:22:48 PST 
Created attachment 124044 [details]
new cpp
Comment 5 Peter Rybin 2012-01-25 17:23:14 PST 
Created attachment 124045 [details]
new h
Comment 6 Yury Semikhatsky 2012-01-27 01:32:58 PST 
The change looks good, but please add a meaningful description of the changes made in this patch to the ChangeLog including introduction of *CommandHandler interfaces and why we need InspectorBackendDispatcher to be an abstract interface. Are we going to have alternative implementation of the dispatcher?
Comment 7 Peter Rybin 2012-01-27 09:13:05 PST 
Created attachment 124327 [details]
Patch
Comment 8 Yury Semikhatsky 2012-01-30 00:57:39 PST 
Comment on attachment 124327 [details]
Patch

Clearing flags on attachment: 124327

Committed r106218: <http://trac.webkit.org/changeset/106218>
Comment 9 Yury Semikhatsky 2012-01-30 00:57:55 PST 
All reviewed patches have been landed.  Closing bug.