| Summary: | [chromium] Rollout r100751, this mechanism does not work and is very slow | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 70556 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
James Robinson
2012-01-25 15:55:22 PST
Created attachment 124027 [details]
Patch
Created attachment 124028 [details]
Patch for landing
Comment on attachment 124028 [details] Patch for landing Rejecting attachment 124028 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ViewImpl.o CXX(target) out/Debug/obj.target/webkit/Source/WebKit/chromium/src/WebMediaElement.o Source/WebKit/chromium/src/WebLayerTreeView.cpp: In member function 'WebKit::WebLayerTreeView::Settings::operator WebCore::CCSettings() const': Source/WebKit/chromium/src/WebLayerTreeView.cpp:45: error: 'struct WebCore::CCSettings' has no member named 'refreshRate' make: *** [out/Debug/obj.target/webkit/Source/WebKit/chromium/src/WebLayerTreeView.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/11265083 Created attachment 124050 [details]
Patch for landing
Trying a less intrusive rollout (the CCSettings code is fine as is, it's just the WebViewImpl bit I'm targetting). Comment on attachment 124050 [details] Patch for landing Clearing flags on attachment: 124050 Committed r105961: <http://trac.webkit.org/changeset/105961> All reviewed patches have been landed. Closing bug. |